AcoSail/llvm-project
8
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
73a01952b5
llvm-project/clang/lib/Serialization
History
Krasimir Georgiev 1e0709167f Revert "[Modules] Remove unnecessary check when generating name lookup table in ASTWriter" 
This reverts commit db987b9589.

We're seeing failures in modules-enabled builds from within stdlib after
this commit. Errors look like:

In module '...stl_cc_library':
...optional:560:38: error: 'std::__optional_copy_assign_base<unsigned
long>::__optional_copy_assign_base' from module '...optional' is not
present in definition of 'std::__optional_copy_assign_base<unsigned
long>' in module '...optional'
    using __optional_move_base<_Tp>::__optional_move_base;

In module '...stl_cc_library':
...optional:771:11: error: no matching constructor for initialization of '__optional_move_assign_base<unsigned long>'
        : __base(in_place, _VSTD::forward<_Up>(__v)) {}
          ^      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
llvm-project/clang/include/clang/Basic/CodeGenOptions.h:448:57: note: in instantiation of function template specialization 'std::optional<unsigned long>::optional<int, 0>' requested here
  std::optional<uint64_t> DiagnosticsHotnessThreshold = 0;

I don't have a self-contained reproducer at this point. I'm hoping that
we may be able to share more information about these issues later, if
necessary.
2023-03-10 14:14:55 +01:00
..
ASTCommon.cpp [WebAssembly] Initial support for reference type externref in clang 2023-02-17 18:48:48 -08:00
ASTCommon.h
ASTReader.cpp [C++20] [Modules] Deprecate to load C++20 Modules eagerly 2023-03-03 14:25:33 +08:00
ASTReaderDecl.cpp [Serialization] Don't warn when a deserialized category is equivalent to an existing one. 2023-02-22 11:01:40 -08:00
ASTReaderInternals.h
ASTReaderStmt.cpp Revert "[Clang] Refactor "Designators" into a unified implementation [NFC]" 2023-03-02 12:09:29 -08:00
ASTWriter.cpp Revert "[Modules] Remove unnecessary check when generating name lookup table in ASTWriter" 2023-03-10 14:14:55 +01:00
ASTWriterDecl.cpp [C++20] [Modules] Don't load declaration eagerly for named modules 2023-03-10 14:57:21 +08:00
ASTWriterStmt.cpp Revert "[Clang] Refactor "Designators" into a unified implementation [NFC]" 2023-03-02 12:09:29 -08:00
CMakeLists.txt [Support] Move TargetParsers to new component 2022-12-20 11:05:50 +00:00
GeneratePCH.cpp
GlobalModuleIndex.cpp Undo a bit of fcf4e360ba that confuses MSVC 2022-12-04 20:33:25 +01:00
InMemoryModuleCache.cpp
ModuleFile.cpp
ModuleFileExtension.cpp
ModuleManager.cpp [Clang] Prepare for llvm::Optional becoming std::optional. 2022-12-20 00:41:40 +01:00
MultiOnDiskHashTable.h
PCHContainerOperations.cpp