64ab2b1dcc
Instead of dumping the string literal (which quotes it and escape every non-ascii symbol), we can use the content of the string when it is a 8 byte string. Wide, UTF-8/UTF-16/32 strings are still completely escaped, until we clarify how these entities should behave (cf https://wg21.link/p2361). `FormatDiagnostic` is modified to escape non printable characters and invalid UTF-8. This ensures that unicode characters, spaces and new lines are properly rendered in static messages. This make clang more consistent with other implementation and fixes this tweet https://twitter.com/jfbastien/status/1298307325443231744 :) Of note, `PaddingChecker` did print out new lines that were later removed by the diagnostic printing code. To be consistent with its tests, the new lines are removed from the diagnostic. Unicode tables updated to both use the Unicode definitions and the Unicode 14.0 data. U+00AD SOFT HYPHEN is still considered a print character to match existing practices in terminals, in addition of being considered a formatting character as per Unicode. Reviewed By: aaron.ballman, #clang-language-wg Differential Revision: https://reviews.llvm.org/D108469
12 lines
422 B
C
12 lines
422 B
C
// RUN: %clang_cc1 %s -verify
|
||
// RUN: not %clang_cc1 %s 2>&1 | FileCheck %s
|
||
|
||
// There is a special characters on the following line, which is used as a
|
||
// marker character for diagnostic printing. Ensure diagnostics involving
|
||
// this character does not cause problems with the diagnostic printer.
|
||
#error Hi Bye
|
||
// expected-error@-1 {{Hi <U+007F> Bye}}
|
||
|
||
// CHECK: error: Hi <U+007F> Bye
|
||
// CHECK: #error Hi <U+007F> Bye
|