AcoSail/wayland
8
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 1 Wiki Activity

tests: Require base 10 for the string specifying the number of open fd's

Browse Source 
The third arg to strtol() specifies the base to assume for the number.
When 0 is passed, as is currently done in wayland-client.c, hexadecimal
and octal numbers are permitted and automatically detected and
converted.

exec-fd-leak-checker's single argument is the count of file descriptors
it should expect to be open.  We should expect this to be specified only
as a decimal number, there's no reason why one would want to use octal
or hexadecimal for that.

Suggested by Yong Bakos.

Signed-off-by: Bryce Harrington <bryce@osg.samsung.com>
Reviewed-by: Yong Bakos <ybakos@humanoriented.com>
This commit is contained in:
Bryce Harrington 2016-07-08 19:00:20 -07:00
parent d6d7dab487
commit 1cda73f3f8
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tests/exec-fd-leak-checker.c
View File

@ -37,7 +37,7 @@ parse_count(const char *str, int *value)
long v;
errno = 0;
v = strtol(str, &end, 0);
v = strtol(str, &end, 10);
if ((errno == ERANGE && (v == LONG_MAX || v == LONG_MIN)) ||
(errno != 0 && v == 0) ||
(end == str) ||