53d24713a3
The update callback for the file descriptors was always a bit awkward and un-intuitive. The idea was that whenever the protocol code needed to write data to the fd it would call the 'update' function. This function would adjust the mainloop so that it polls for POLLOUT on the fd so we can eventually flush the data to the socket. The problem is that in multi-threaded applications, any thread can issue a request, which writes data to the output buffer and thus triggers the update callback. Thus, we'll be calling out with the display mutex held and may call from any thread. The solution is to eliminate the udpate callback and just require that the application or server flushes all connection buffers before blocking. This turns out to be a simpler API, although we now require clients to deal with EAGAIN and non-blocking writes. It also saves a few syscalls, since the socket will be writable most of the time and most writes will complete, so we avoid changing epoll to poll for POLLOUT, then write and then change it back for each write. |
||
|---|---|---|
| .. | ||
| .gitignore | ||
| array-test.c | ||
| client-test.c | ||
| connection-test.c | ||
| event-loop-test.c | ||
| exec-fd-leak-checker.c | ||
| fixed-benchmark.c | ||
| fixed-test.c | ||
| list-test.c | ||
| Makefile.am | ||
| map-test.c | ||
| os-wrappers-test.c | ||
| sanity-test.c | ||
| socket-test.c | ||
| test-helpers.c | ||
| test-runner.c | ||
| test-runner.h | ||