go-sylixos/elvish
3
0
Fork 0
mirror of https://github.com/go-sylixos/elvish.git synced 2024-12-12 17:27:50 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix handling of unexpected errors

Browse Source 
Doing something like the following is likely to result in too many open
files (assuming `ulimit -n` == 256) resulting in a panic:

    > fn fact [n]{ if (== $n 0) { put 1 } else { put (* $n (fact (- $n 1))) } }
    > fact 60
    panic: interface conversion: error is *os.SyscallError, not
    *eval.Exception

    goroutine 24161 [running]:
    github.com/elves/elvish/pkg/eval.(*pipelineOp).exec.func1(0x152a5a0,
    0xc000dca210, 0xc000a44e70, 0xc00057b540, 0xc001030590, 0x203000)
        github.com/elves/elvish/pkg/eval/compile_effect.go:153 +0x152
    created by github.com/elves/elvish/pkg/eval.(*pipelineOp).exec
        github.com/elves/elvish/pkg/eval/compile_effect.go:149 +0x225
    Exception: elvish exited with 2

Fixes #1208
This commit is contained in:
Kurtis Rader 2021-01-06 18:27:54 -08:00 committed by Qi Xiao
parent 9af4c83bf6
commit 5564c8f754
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
pkg/eval/compile_effect.go
View File

@ -139,7 +139,12 @@ func (op *pipelineOp) exec(fm *Frame) error {
err := thisOp.exec(newFm)
newFm.Close()
if err != nil {
*thisError = err.(*Exception)
switch err := err.(type) {
case *Exception:
*thisError = err
default:
*thisError = &Exception{Reason: err, StackTrace: nil}
}
}
wg.Done()
if hasChanInput {