go-sylixos/elvish
3
0
Fork 0
mirror of https://github.com/go-sylixos/elvish.git synced 2024-12-14 19:27:58 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

edit: Call after-readline hooks before tearing down editor.

Browse Source 
This fixes #589.
This commit is contained in:
Qi Xiao 2018-02-10 11:16:48 -08:00
parent c8cf6a1f61
commit b77b3d7846
1 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
edit/edit.go
View File

@ -310,6 +310,12 @@ func (ed *editor) startReadLine() error {
// finishReadLine puts the terminal in a state suitable for other programs to
// use.
func (ed *editor) finishReadLine() error {
// After-readline hooks should be called before most teardown happens as
// they can cause the editor to refresh.
for _, f := range ed.afterReadline {
f(ed.buffer)
}
ed.activeMutex.Lock()
defer ed.activeMutex.Unlock()
ed.active = false
@ -331,14 +337,9 @@ func (ed *editor) finishReadLine() error {
// Restore termios.
errRestore := ed.restoreTerminal()
// Save the line before resetting all of editorState.
line := ed.buffer
// Reset all of editorState.
ed.editorState = editorState{}
for _, f := range ed.afterReadline {
f(line)
}
return util.Errors(errRefresh, errRestore)
}