elvish/pkg/eval/builtin_fn_misc_test.go
Qi Xiao 363b712f66 pkg/eval: Eliminate in-place mutations of *Ns.
This commit replaces scopeOp, the only remaining place that mutates *Ns in
place, with nsOp, which performs copy-on-write for *Ns.

As a result, the "eval" command no longer mutates the passed namespace. The
default namespace it uses is also changed to match the default of "-source" (an
amalgamated namespace from the local and upvalue scopes), making "-source $file"
equivalent to "eval (slurp <$file)", and formally deprecated.

Another result is that (*Evaler).Eval can now guard the mutation of the global
namespace with the mutex, making it concurrency-safe to execute multiple sources
that touch the global namespace.

This fixes #1137.
2021-01-09 15:02:15 +00:00

139 lines
4.5 KiB
Go

package eval_test
import (
"errors"
"testing"
"time"
. "github.com/elves/elvish/pkg/eval"
. "github.com/elves/elvish/pkg/eval/evaltest"
"github.com/elves/elvish/pkg/eval/vals"
"github.com/elves/elvish/pkg/testutil"
)
func TestBuiltinFnMisc(t *testing.T) {
Test(t,
That(`f = (constantly foo); $f; $f`).Puts("foo", "foo"),
// eval
// ====
That("eval 'put x'").Puts("x"),
// Using variable from the local scope.
That("x = foo; eval 'put $x'").Puts("foo"),
// Setting a variable in the local scope.
That("x = foo; eval 'x = bar'; put $x").Puts("bar"),
// Using variable from the upvalue scope.
That("x = foo; { nop $x; eval 'put $x' }").Puts("foo"),
// Specifying a namespace.
That("n = (ns [&x=foo]); eval 'put $x' &ns=$n").Puts("foo"),
// Altering variables in the specified namespace.
That("n = (ns [&x=foo]); eval 'x = bar' &ns=$n; put $n[x]").Puts("bar"),
// Newly created variables do not appear in the local namespace.
That("eval 'x = foo'; put $x").DoesNotCompile(),
// Newly created variables do not alter the specified namespace, either.
That("n = (ns [&]); eval &ns=$n 'x = foo'; put $n[x]").
Throws(vals.NoSuchKey("x"), "$n[x]"),
// However, newly created variable can be accessed in the final
// namespace using &on-end.
That("eval &on-end=[n]{ put $n[x] } 'x = foo'").Puts("foo"),
// Parse error.
That("eval '['").Throws(AnyError),
// Compilation error.
That("eval 'put $x'").Throws(AnyError),
// Exception.
That("eval 'fail x'").Throws(FailError{"x"}),
// Test the "time" builtin.
//
// Since runtime duration is non-deterministic, we only have some sanity
// checks here.
That("time { echo foo } | a _ = (all)", "put $a").Puts("foo"),
That("duration = ''",
"time &on-end=[x]{ duration = $x } { echo foo } | out = (all)",
"put $out", "kind-of $duration").Puts("foo", "number"),
That("time { fail body } | nop (all)").Throws(FailError{"body"}),
That("time &on-end=[_]{ fail on-end } { }").Throws(
FailError{"on-end"}),
That("time &on-end=[_]{ fail on-end } { fail body }").Throws(
FailError{"body"}),
)
}
func TestSource(t *testing.T) {
_, cleanup := testutil.InTestDir()
defer cleanup()
Test(t,
// Smoke test
That("echo 'put x' > a.elv; -source a.elv").Puts("x"),
// Sourced files have access to the local scope
That("echo 'put $x' > a.elv; [x]{ -source a.elv } foo").Puts("foo"),
// Mutation to the namespace is not persisted.
That("echo 'x = foo ' > a.elv; echo 'put $x' > b.elv",
"-source a.elv; -source b.elv").Throws(AnyError, "-source b.elv"),
// Regression test for #1202.
That("echo 'b = bar' > b.elv; a = foo; { nop $a; -source b.elv }").
DoesNothing(),
)
}
func TestUseMod(t *testing.T) {
_, cleanup := testutil.InTestDir()
defer cleanup()
testutil.MustWriteFile("mod.elv", []byte("x = value"), 0600)
Test(t,
That("put (use-mod ./mod)[x]").Puts("value"),
)
}
func timeAfterMock(fm *Frame, d time.Duration) <-chan time.Time {
fm.OutputChan() <- d // report to the test framework the duration we received
return time.After(0)
}
func TestSleep(t *testing.T) {
TimeAfter = timeAfterMock
Test(t,
That(`sleep 0`).Puts(0*time.Second),
That(`sleep 1`).Puts(1*time.Second),
That(`sleep 1.3s`).Puts(1300*time.Millisecond),
That(`sleep 0.1`).Puts(100*time.Millisecond),
That(`sleep 0.1ms`).Puts(100*time.Microsecond),
That(`sleep 3h5m7s`).Puts((3*3600+5*60+7)*time.Second),
That(`sleep 1x`).Throws(errors.New("invalid sleep duration"), "sleep 1x"),
That(`sleep -7`).Throws(errors.New("sleep duration must be >= zero"), "sleep -7"),
That(`sleep -3h`).Throws(errors.New("sleep duration must be >= zero"), "sleep -3h"),
// Verify the correct behavior if a number rather than a string is
// passed to the command.
That(`sleep (float64 0)`).Puts(0*time.Second),
That(`sleep (float64 1.7)`).Puts(1700*time.Millisecond),
That(`sleep (float64 -7)`).Throws(
errors.New("sleep duration must be >= zero"),
"sleep (float64 -7)"),
// An invalid argument type should raise an exception.
That(`sleep [1]`).Throws(errors.New("invalid sleep duration"), "sleep [1]"),
)
}
func TestResolve(t *testing.T) {
libdir, cleanup := testutil.InTestDir()
defer cleanup()
testutil.MustWriteFile("mod.elv", []byte("fn func { }"), 0600)
TestWithSetup(t, func(ev *Evaler) { ev.SetLibDir(libdir) },
That("resolve for").Puts("special"),
That("resolve put").Puts("$put~"),
That("fn f { }; resolve f").Puts("$f~"),
That("use mod; resolve mod:func").Puts("$mod:func~"),
That("resolve cat").Puts("(external cat)"),
That(`resolve external`).Puts("$external~"),
)
}