luck/tmp_suning_uos_patched
1
0
Fork 1
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Input: xpad - remove useless check in xpad_remove

Browse Source 
ixpad can never be NULL here; if it is NULL we would not have been bound to
the interface and then why would we be called?

Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
This commit is contained in:
Dmitry Torokhov 2010-11-11 21:52:18 -08:00
parent 161feb2417
commit 2a0591596b
1 changed files with 18 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

37
drivers/input/joystick/xpad.c
View File

@ -993,22 +993,24 @@ static void xpad_disconnect(struct usb_interface *intf)
{ {
struct usb_xpad *xpad = usb_get_intfdata (intf); struct usb_xpad *xpad = usb_get_intfdata (intf);
usb_set_intfdata(intf, NULL); xpad_led_disconnect(xpad);
if (xpad) { input_unregister_device(xpad->dev);
xpad_led_disconnect(xpad); xpad_deinit_output(xpad);
input_unregister_device(xpad->dev);
xpad_deinit_output(xpad); if (xpad->xtype == XTYPE_XBOX360W) {
if (xpad->xtype == XTYPE_XBOX360W) { usb_kill_urb(xpad->bulk_out);
usb_kill_urb(xpad->bulk_out); usb_free_urb(xpad->bulk_out);
usb_free_urb(xpad->bulk_out); usb_kill_urb(xpad->irq_in);
usb_kill_urb(xpad->irq_in);
}
usb_free_urb(xpad->irq_in);
usb_free_coherent(xpad->udev, XPAD_PKT_LEN,
xpad->idata, xpad->idata_dma);
kfree(xpad->bdata);
kfree(xpad);
} }
usb_free_urb(xpad->irq_in);
usb_free_coherent(xpad->udev, XPAD_PKT_LEN,
xpad->idata, xpad->idata_dma);
kfree(xpad->bdata);
kfree(xpad);
usb_set_intfdata(intf, NULL);
} }
static struct usb_driver xpad_driver = { static struct usb_driver xpad_driver = {
@ -1020,10 +1022,7 @@ static struct usb_driver xpad_driver = {
static int __init usb_xpad_init(void) static int __init usb_xpad_init(void)
{ {
int result = usb_register(&xpad_driver); return usb_register(&xpad_driver);
if (result == 0)
printk(KERN_INFO KBUILD_MODNAME ": " DRIVER_DESC "\n");
return result;
} }
static void __exit usb_xpad_exit(void) static void __exit usb_xpad_exit(void)