nfsd4: memory corruption in numeric_name_to_id()
"id" is type is a uid_t (32 bits) but on 64 bit systems strict_strtoul() modifies 64 bits of data. We should use kstrtouint() instead. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: J. Bruce Fields <bfields@redhat.com>
This commit is contained in:
parent
92769108f5
commit
3af706135b
@ -581,7 +581,7 @@ numeric_name_to_id(struct svc_rqst *rqstp, int type, const char *name, u32 namel
|
||||
/* Just to make sure it's null-terminated: */
|
||||
memcpy(buf, name, namelen);
|
||||
buf[namelen] = '\0';
|
||||
ret = strict_strtoul(name, 10, (unsigned long *)id);
|
||||
ret = kstrtouint(name, 10, id);
|
||||
return ret == 0;
|
||||
}
|
||||
|
||||
|
Loading…
Reference in New Issue
Block a user