[CPUFREQ] Fix sysfs_create_file return value handling
Commit 0a4b2ccc55
in cpufreq.git
eliminates the build warnings but does not pass on the error code of
sysfs_create_file to the function calling cpufreq_add_dev. Instead some
previous value of ret would be returned.
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Signed-off-by: Dave Jones <davej@redhat.com>
This commit is contained in:
parent
ea48761519
commit
58a7295bc8
@ -826,16 +826,19 @@ static int cpufreq_add_dev (struct sys_device * sys_dev)
|
|||||||
/* set up files for this cpu device */
|
/* set up files for this cpu device */
|
||||||
drv_attr = cpufreq_driver->attr;
|
drv_attr = cpufreq_driver->attr;
|
||||||
while ((drv_attr) && (*drv_attr)) {
|
while ((drv_attr) && (*drv_attr)) {
|
||||||
if (sysfs_create_file(&policy->kobj, &((*drv_attr)->attr)))
|
ret = sysfs_create_file(&policy->kobj, &((*drv_attr)->attr));
|
||||||
|
if (ret)
|
||||||
goto err_out_driver_exit;
|
goto err_out_driver_exit;
|
||||||
drv_attr++;
|
drv_attr++;
|
||||||
}
|
}
|
||||||
if (cpufreq_driver->get){
|
if (cpufreq_driver->get){
|
||||||
if (sysfs_create_file(&policy->kobj, &cpuinfo_cur_freq.attr))
|
ret = sysfs_create_file(&policy->kobj, &cpuinfo_cur_freq.attr);
|
||||||
|
if (ret)
|
||||||
goto err_out_driver_exit;
|
goto err_out_driver_exit;
|
||||||
}
|
}
|
||||||
if (cpufreq_driver->target){
|
if (cpufreq_driver->target){
|
||||||
if (sysfs_create_file(&policy->kobj, &scaling_cur_freq.attr))
|
ret = sysfs_create_file(&policy->kobj, &scaling_cur_freq.attr);
|
||||||
|
if (ret)
|
||||||
goto err_out_driver_exit;
|
goto err_out_driver_exit;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
Loading…
Reference in New Issue
Block a user