luck/tmp_suning_uos_patched
1
0
Fork 1
Code Issues Pull Requests Packages Projects Releases Wiki Activity

i2c: i2c-boardinfo: fix memory leaks on devinfo

Browse Source 
Currently when an error occurs devinfo is still allocated but is
unused when the error exit paths break out of the for-loop. Fix
this by kfree'ing devinfo to avoid the leak.

Detected by CoverityScan, CID#1416590 ("Resource Leak")

Fixes: 4124c4eba4 ("i2c: allow attaching IRQ resources to i2c_board_info")
Fixes: 0daaf99d84 ("i2c: copy device properties when using i2c_register_board_info()")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
This commit is contained in:
Colin Ian King 2017-11-22 17:52:24 +00:00 committed by Wolfram Sang
parent 6e0c9507bf
commit 66a7c84d67
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/i2c/i2c-boardinfo.c
View File

@ -86,6 +86,7 @@ int i2c_register_board_info(int busnum, struct i2c_board_info const *info, unsig
property_entries_dup(info->properties); property_entries_dup(info->properties);
if (IS_ERR(devinfo->board_info.properties)) { if (IS_ERR(devinfo->board_info.properties)) {
status = PTR_ERR(devinfo->board_info.properties); status = PTR_ERR(devinfo->board_info.properties);
kfree(devinfo);
break; break;
} }
} }
@ -98,6 +99,7 @@ int i2c_register_board_info(int busnum, struct i2c_board_info const *info, unsig
GFP_KERNEL); GFP_KERNEL);
if (!devinfo->board_info.resources) { if (!devinfo->board_info.resources) {
status = -ENOMEM; status = -ENOMEM;
kfree(devinfo);
break; break;
} }
} }