ocfs2: Use ERR_CAST() to avoid cross-structure cast
When trying to propagate an error result, the error return path attempts to retain the error, but does this with an open cast across very different types, which the upcoming structure layout randomization plugin flags as being potentially dangerous in the face of randomization. This is a false positive, but what this code actually wants to do is use ERR_CAST() to retain the error value. Cc: Mark Fasheh <mfasheh@versity.com> Cc: Joel Becker <jlbec@evilplan.org> Signed-off-by: Kees Cook <keescook@chromium.org>
This commit is contained in:
parent
fee2aa7538
commit
7585d12f65
|
@ -119,7 +119,7 @@ static struct dentry *ocfs2_get_dentry(struct super_block *sb,
|
||||||
|
|
||||||
if (IS_ERR(inode)) {
|
if (IS_ERR(inode)) {
|
||||||
mlog_errno(PTR_ERR(inode));
|
mlog_errno(PTR_ERR(inode));
|
||||||
result = (void *)inode;
|
result = ERR_CAST(inode);
|
||||||
goto bail;
|
goto bail;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
Loading…
Reference in New Issue
Block a user