sctp: translate network order to host order when users get a hmacid
Commited5a377d87
("sctp: translate host order to network order when setting a hmacid") corrected the hmacid byte-order when setting a hmacid. but the same issue also exists on getting a hmacid. We fix it by changing hmacids to host order when users get them with getsockopt. Fixes: Commited5a377d87
("sctp: translate host order to network order when setting a hmacid") Signed-off-by: Xin Long <lucien.xin@gmail.com> Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
ca7f41a495
commit
7a84bd4664
|
@ -5538,6 +5538,7 @@ static int sctp_getsockopt_hmac_ident(struct sock *sk, int len,
|
|||
struct sctp_hmac_algo_param *hmacs;
|
||||
__u16 data_len = 0;
|
||||
u32 num_idents;
|
||||
int i;
|
||||
|
||||
if (!ep->auth_enable)
|
||||
return -EACCES;
|
||||
|
@ -5555,8 +5556,12 @@ static int sctp_getsockopt_hmac_ident(struct sock *sk, int len,
|
|||
return -EFAULT;
|
||||
if (put_user(num_idents, &p->shmac_num_idents))
|
||||
return -EFAULT;
|
||||
if (copy_to_user(p->shmac_idents, hmacs->hmac_ids, data_len))
|
||||
return -EFAULT;
|
||||
for (i = 0; i < num_idents; i++) {
|
||||
__u16 hmacid = ntohs(hmacs->hmac_ids[i]);
|
||||
|
||||
if (copy_to_user(&p->shmac_idents[i], &hmacid, sizeof(__u16)))
|
||||
return -EFAULT;
|
||||
}
|
||||
return 0;
|
||||
}
|
||||
|
||||
|
|
Loading…
Reference in New Issue
Block a user