luck/tmp_suning_uos_patched
1
0
Fork 1
Code Issues Pull Requests Packages Projects Releases Wiki Activity

remoteproc: avoid stack overflow in debugfs file

Browse Source 
Recent gcc versions warn about reading from a negative offset of
an on-stack array:

drivers/remoteproc/remoteproc_debugfs.c: In function 'rproc_recovery_write':
drivers/remoteproc/remoteproc_debugfs.c:167:9: warning: 'buf[4294967295u]' may be used uninitialized in this function [-Wmaybe-uninitialized]

I don't see anything in sys_write() that prevents us from
being called with a zero 'count' argument, so we should
add an extra check in rproc_recovery_write() to prevent the
access and avoid the warning.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 2e37abb89a ("remoteproc: create a 'recovery' debugfs entry")
Signed-off-by: Ohad Ben-Cohen <ohad@wizery.com>
This commit is contained in:
Arnd Bergmann 2015-11-20 18:26:07 +01:00 committed by Ohad Ben-Cohen
parent 1ec218373b
commit 92792e48e2
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/remoteproc/remoteproc_debugfs.c
View File

@ -156,7 +156,7 @@ rproc_recovery_write(struct file *filp, const char __user *user_buf,
char buf[10]; char buf[10];
int ret; int ret;
if (count > sizeof(buf)) if (count < 1 || count > sizeof(buf))
return count; return count;
ret = copy_from_user(buf, user_buf, count); ret = copy_from_user(buf, user_buf, count);