ktest: Still do reboot even for REBOOT_TYPE = script
The REBOOT_TYPE may be either grub or script, if it is script it is expected that a REBOOT_SCRIPT is defined. With the SWITCH_TO_TEST which is the complement of SWITCH_TO_GOOD, which does basically the same thing as REBOOT_SCRIPT and but for both grub and script, the REBOOT_SCRIPT does not need to be mandatory anymore. Do not require the REBOOT_SCRIPT and always run the reboot code for both grub and script. Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
This commit is contained in:
parent
c2857cb4a8
commit
96f6a0df19
@ -485,8 +485,6 @@ sub get_ktest_configs {
|
||||
|
||||
if ($rtype eq "grub") {
|
||||
get_ktest_config("GRUB_MENU");
|
||||
} else {
|
||||
get_ktest_config("REBOOT_SCRIPT");
|
||||
}
|
||||
}
|
||||
|
||||
@ -1430,11 +1428,10 @@ sub reboot_to {
|
||||
|
||||
if ($reboot_type eq "grub") {
|
||||
run_ssh "'(echo \"savedefault --default=$grub_number --once\" | grub --batch)'";
|
||||
reboot;
|
||||
return;
|
||||
} elsif (defined $reboot_script) {
|
||||
run_command "$reboot_script";
|
||||
}
|
||||
|
||||
run_command "$reboot_script";
|
||||
reboot;
|
||||
}
|
||||
|
||||
sub get_sha1 {
|
||||
@ -3479,8 +3476,6 @@ for (my $i = 1; $i <= $opt{"NUM_TESTS"}; $i++) {
|
||||
$target = "$ssh_user\@$machine";
|
||||
if ($reboot_type eq "grub") {
|
||||
dodie "GRUB_MENU not defined" if (!defined($grub_menu));
|
||||
} elsif (!defined($reboot_script)) {
|
||||
dodie "REBOOT_SCRIPT not defined"
|
||||
}
|
||||
}
|
||||
|
||||
|
@ -346,7 +346,10 @@
|
||||
#GRUB_MENU = Test Kernel
|
||||
|
||||
# A script to reboot the target into the test kernel
|
||||
# (Only mandatory if REBOOT_TYPE = script)
|
||||
# This and SWITCH_TO_TEST are about the same, except
|
||||
# SWITCH_TO_TEST is run even for REBOOT_TYPE = grub.
|
||||
# This may be left undefined.
|
||||
# (default undefined)
|
||||
#REBOOT_SCRIPT =
|
||||
|
||||
#### Optional Config Options (all have defaults) ####
|
||||
|
Loading…
Reference in New Issue
Block a user