mtd: gen_probe: Use struct_size() in kmalloc()
One of the more common cases of allocation size calculations is finding the size of a structure that has a zero-sized array at the end, along with memory for some number of elements for that array. For example: struct foo { int stuff; void *entry[]; }; instance = kmalloc(sizeof(struct foo) + sizeof(void *) * count, GFP_KERNEL); Instead of leaving these open-coded and prone to type mistakes, we can now use the new struct_size() helper: instance = kmalloc(struct_size(instance, entry, count), GFP_KERNEL); This code was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> Signed-off-by: Boris Brezillon <bbrezillon@kernel.org>
This commit is contained in:
parent
f9d27de6fa
commit
9cb76a6aa1
|
@ -135,7 +135,7 @@ static struct cfi_private *genprobe_ident_chips(struct map_info *map, struct chi
|
||||||
* our caller, and copy the appropriate data into them.
|
* our caller, and copy the appropriate data into them.
|
||||||
*/
|
*/
|
||||||
|
|
||||||
retcfi = kmalloc(sizeof(struct cfi_private) + cfi.numchips * sizeof(struct flchip), GFP_KERNEL);
|
retcfi = kmalloc(struct_size(retcfi, chips, cfi.numchips), GFP_KERNEL);
|
||||||
|
|
||||||
if (!retcfi) {
|
if (!retcfi) {
|
||||||
kfree(cfi.cfiq);
|
kfree(cfi.cfiq);
|
||||||
|
|
Loading…
Reference in New Issue
Block a user