luck/tmp_suning_uos_patched
1
0
Fork 1
Code Issues Pull Requests Packages Projects Releases Wiki Activity

pata_octeon_cf: use of_property_read_{bool|u32}()

Browse Source 
The Octeon CF driver basically  open-codes of_property_read_{bool|u32}()
using  of_{find|get}_property() calls in its  probe() method.  Using the
modern DT APIs saves 2 LoCs and 16 bytes of object code (MIPS gcc 3.4.3).

Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
This commit is contained in:
Sergei Shtylyov 2017-08-27 22:55:09 +03:00 committed by Tejun Heo
parent 591b6bb605
commit be1dc3fb29
1 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/ata/pata_octeon_cf.c
View File

@ -840,7 +840,6 @@ static int octeon_cf_probe(struct platform_device *pdev)
struct property *reg_prop; struct property *reg_prop;
int n_addr, n_size, reg_len; int n_addr, n_size, reg_len;
struct device_node *node; struct device_node *node;
const void *prop;
void __iomem *cs0; void __iomem *cs0;
void __iomem *cs1 = NULL; void __iomem *cs1 = NULL;
struct ata_host *host; struct ata_host *host;
@ -850,7 +849,7 @@ static int octeon_cf_probe(struct platform_device *pdev)
void __iomem *base; void __iomem *base;
struct octeon_cf_port *cf_port; struct octeon_cf_port *cf_port;
int rv = -ENOMEM; int rv = -ENOMEM;
u32 bus_width;
node = pdev->dev.of_node; node = pdev->dev.of_node;
if (node == NULL) if (node == NULL)
@ -860,11 +859,10 @@ static int octeon_cf_probe(struct platform_device *pdev)
if (!cf_port) if (!cf_port)
return -ENOMEM; return -ENOMEM;
cf_port->is_true_ide = (of_find_property(node, "cavium,true-ide", NULL) != NULL); cf_port->is_true_ide = of_property_read_bool(node, "cavium,true-ide");
prop = of_get_property(node, "cavium,bus-width", NULL); if (of_property_read_u32(node, "cavium,bus-width", &bus_width) == 0)
if (prop) is_16bit = (bus_width == 16);
is_16bit = (be32_to_cpup(prop) == 16);
else else
is_16bit = false; is_16bit = false;