KVM: arm64: vgic-its: Fix handling of indirect tables

The current code will fail on valid indirect tables, and happily
use the ones that are pointing out of the guest RAM. Funny what a
small "!" can do for you...

Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
This commit is contained in:
Marc Zyngier 2016-07-18 16:16:26 +01:00
parent d97594e6bc
commit c0091073dd

View File

@ -702,9 +702,9 @@ static bool vgic_its_check_device_id(struct kvm *kvm, struct vgic_its *its,
return false;
/* Each 1st level entry is represented by a 64-bit value. */
if (!kvm_read_guest(kvm,
BASER_ADDRESS(r) + index * sizeof(indirect_ptr),
&indirect_ptr, sizeof(indirect_ptr)))
if (kvm_read_guest(kvm,
BASER_ADDRESS(r) + index * sizeof(indirect_ptr),
&indirect_ptr, sizeof(indirect_ptr)))
return false;
/* check the valid bit of the first level entry */