luck/tmp_suning_uos_patched
1
0
Fork 1
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mfd: twl6030: Cleanup interrupt handling

Browse Source 
irq_desc checking in the interrupt demux routine is totally
pointless. The driver sets those lines up, so that cant go away
magically.

Remove the open coded handler magic and use the proper accessor.

This driver needs to be converted to threaded interrupts and buslock.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
This commit is contained in:
Thomas Gleixner 2011-03-25 11:12:31 +00:00 committed by Samuel Ortiz
parent d740f4523b
commit c22435a307
1 changed files with 1 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
drivers/mfd/twl6030-irq.c
View File

@ -140,22 +140,7 @@ static int twl6030_irq_thread(void *data)
if (sts.int_sts & 0x1) { if (sts.int_sts & 0x1) {
int module_irq = twl6030_irq_base + int module_irq = twl6030_irq_base +
twl6030_interrupt_mapping[i]; twl6030_interrupt_mapping[i];
struct irq_desc *d = irq_to_desc(module_irq); generic_handle_irq(module_irq);
if (!d) {
pr_err("twl6030: Invalid SIH IRQ: %d\n",
module_irq);
return -EINVAL;
}
/* These can't be masked ... always warn
* if we get any surprises.
*/
if (d->status & IRQ_DISABLED)
note_interrupt(module_irq, d,
IRQ_NONE);
else
d->handle_irq(module_irq, d);
} }
local_irq_enable(); local_irq_enable();