99d50b9b8c
Commit c31e73121f ("base: soc: Handle custom soc information sysfs
entries") introduced custom soc attribute group in soc_device_attribute
structure but there are no users treewide. While trying to understand
the motivation and tried to use it, it was found lot of existing custom
attributes can moved to use it instead of device_create_file.
Though most of these never remove/cleanup the custom attribute as they
never call soc_device_unregister, using these custom attribute group
eliminate the need for any cleanup as the driver infrastructure will
take care of that.
Let us remove device_create_file and start using the custom attribute
group in soc_device_attribute.
Link: https://lore.kernel.org/r/20200523170859.50003-3-sudeep.holla@arm.com
Cc: Linus Walleij <linus.walleij@linaro.org>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
133 lines
3.1 KiB
C
133 lines
3.1 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
/*
|
|
* Copyright (C) 2014 Linaro Ltd.
|
|
*
|
|
* Author: Linus Walleij <linus.walleij@linaro.org>
|
|
*/
|
|
#include <linux/init.h>
|
|
#include <linux/io.h>
|
|
#include <linux/slab.h>
|
|
#include <linux/sys_soc.h>
|
|
#include <linux/platform_device.h>
|
|
#include <linux/mfd/syscon.h>
|
|
#include <linux/regmap.h>
|
|
#include <linux/of.h>
|
|
|
|
/* System ID in syscon */
|
|
#define REALVIEW_SYS_ID_OFFSET 0x00
|
|
|
|
static const struct of_device_id realview_soc_of_match[] = {
|
|
{ .compatible = "arm,realview-eb-soc", },
|
|
{ .compatible = "arm,realview-pb1176-soc", },
|
|
{ .compatible = "arm,realview-pb11mp-soc", },
|
|
{ .compatible = "arm,realview-pba8-soc", },
|
|
{ .compatible = "arm,realview-pbx-soc", },
|
|
{ }
|
|
};
|
|
|
|
static u32 realview_coreid;
|
|
|
|
static const char *realview_arch_str(u32 id)
|
|
{
|
|
switch ((id >> 8) & 0xf) {
|
|
case 0x04:
|
|
return "AHB";
|
|
case 0x05:
|
|
return "Multi-layer AXI";
|
|
default:
|
|
return "Unknown";
|
|
}
|
|
}
|
|
|
|
static ssize_t
|
|
manufacturer_show(struct device *dev, struct device_attribute *attr, char *buf)
|
|
{
|
|
return sprintf(buf, "%02x\n", realview_coreid >> 24);
|
|
}
|
|
|
|
static DEVICE_ATTR_RO(manufacturer);
|
|
|
|
static ssize_t
|
|
board_show(struct device *dev, struct device_attribute *attr, char *buf)
|
|
{
|
|
return sprintf(buf, "HBI-%03x\n", ((realview_coreid >> 16) & 0xfff));
|
|
}
|
|
|
|
static DEVICE_ATTR_RO(board);
|
|
|
|
static ssize_t
|
|
fpga_show(struct device *dev, struct device_attribute *attr, char *buf)
|
|
{
|
|
return sprintf(buf, "%s\n", realview_arch_str(realview_coreid));
|
|
}
|
|
|
|
static DEVICE_ATTR_RO(fpga);
|
|
|
|
static ssize_t
|
|
build_show(struct device *dev, struct device_attribute *attr, char *buf)
|
|
{
|
|
return sprintf(buf, "%02x\n", (realview_coreid & 0xFF));
|
|
}
|
|
|
|
static DEVICE_ATTR_RO(build);
|
|
|
|
static struct attribute *realview_attrs[] = {
|
|
&dev_attr_manufacturer.attr,
|
|
&dev_attr_board.attr,
|
|
&dev_attr_fpga.attr,
|
|
&dev_attr_build.attr,
|
|
NULL
|
|
};
|
|
|
|
ATTRIBUTE_GROUPS(realview);
|
|
|
|
static int realview_soc_probe(struct platform_device *pdev)
|
|
{
|
|
struct regmap *syscon_regmap;
|
|
struct soc_device *soc_dev;
|
|
struct soc_device_attribute *soc_dev_attr;
|
|
struct device_node *np = pdev->dev.of_node;
|
|
int ret;
|
|
|
|
syscon_regmap = syscon_regmap_lookup_by_phandle(np, "regmap");
|
|
if (IS_ERR(syscon_regmap))
|
|
return PTR_ERR(syscon_regmap);
|
|
|
|
soc_dev_attr = kzalloc(sizeof(*soc_dev_attr), GFP_KERNEL);
|
|
if (!soc_dev_attr)
|
|
return -ENOMEM;
|
|
|
|
ret = of_property_read_string(np, "compatible",
|
|
&soc_dev_attr->soc_id);
|
|
if (ret)
|
|
return -EINVAL;
|
|
|
|
soc_dev_attr->machine = "RealView";
|
|
soc_dev_attr->family = "Versatile";
|
|
soc_dev_attr->custom_attr_group = realview_groups[0];
|
|
soc_dev = soc_device_register(soc_dev_attr);
|
|
if (IS_ERR(soc_dev)) {
|
|
kfree(soc_dev_attr);
|
|
return -ENODEV;
|
|
}
|
|
ret = regmap_read(syscon_regmap, REALVIEW_SYS_ID_OFFSET,
|
|
&realview_coreid);
|
|
if (ret)
|
|
return -ENODEV;
|
|
|
|
dev_info(&pdev->dev, "RealView Syscon Core ID: 0x%08x, HBI-%03x\n",
|
|
realview_coreid,
|
|
((realview_coreid >> 16) & 0xfff));
|
|
/* FIXME: add attributes for SoC to sysfs */
|
|
return 0;
|
|
}
|
|
|
|
static struct platform_driver realview_soc_driver = {
|
|
.probe = realview_soc_probe,
|
|
.driver = {
|
|
.name = "realview-soc",
|
|
.of_match_table = realview_soc_of_match,
|
|
},
|
|
};
|
|
builtin_platform_driver(realview_soc_driver);
|