Mel Gorman 5d75361027 net, swap: Remove a warning and clarify why sk_mem_reclaim is required when deactivating swap ... Jeff Layton reported the following; [ 74.232485] ------------[ cut here ]------------ [ 74.233354] WARNING: CPU: 2 PID: 754 at net/core/sock.c:364 sk_clear_memalloc+0x51/0x80() [ 74.234790] Modules linked in: cts rpcsec_gss_krb5 nfsv4 dns_resolver nfs fscache xfs libcrc32c snd_hda_codec_generic snd_hda_intel snd_hda_controller snd_hda_codec snd_hda_core snd_hwdep snd_seq snd_seq_device nfsd snd_pcm snd_timer snd e1000 ppdev parport_pc joydev parport pvpanic soundcore floppy serio_raw i2c_piix4 pcspkr nfs_acl lockd virtio_balloon acpi_cpufreq auth_rpcgss grace sunrpc qxl drm_kms_helper ttm drm virtio_console virtio_blk virtio_pci ata_generic virtio_ring pata_acpi virtio [ 74.243599] CPU: 2 PID: 754 Comm: swapoff Not tainted 4.1.0-rc6+ #5 [ 74.244635] Hardware name: Bochs Bochs, BIOS Bochs 01/01/2011 [ 74.245546] 0000000000000000 0000000079e69e31 ffff8800d066bde8 ffffffff8179263d [ 74.246786] 0000000000000000 0000000000000000 ffff8800d066be28 ffffffff8109e6fa [ 74.248175] 0000000000000000 ffff880118d48000 ffff8800d58f5c08 ffff880036e380a8 [ 74.249483] Call Trace: [ 74.249872] [<ffffffff8179263d>] dump_stack+0x45/0x57 [ 74.250703] [<ffffffff8109e6fa>] warn_slowpath_common+0x8a/0xc0 [ 74.251655] [<ffffffff8109e82a>] warn_slowpath_null+0x1a/0x20 [ 74.252585] [<ffffffff81661241>] sk_clear_memalloc+0x51/0x80 [ 74.253519] [<ffffffffa0116c72>] xs_disable_swap+0x42/0x80 [sunrpc] [ 74.254537] [<ffffffffa01109de>] rpc_clnt_swap_deactivate+0x7e/0xc0 [sunrpc] [ 74.255610] [<ffffffffa03e4fd7>] nfs_swap_deactivate+0x27/0x30 [nfs] [ 74.256582] [<ffffffff811e99d4>] destroy_swap_extents+0x74/0x80 [ 74.257496] [<ffffffff811ecb52>] SyS_swapoff+0x222/0x5c0 [ 74.258318] [<ffffffff81023f27>] ? syscall_trace_leave+0xc7/0x140 [ 74.259253] [<ffffffff81798dae>] system_call_fastpath+0x12/0x71 [ 74.260158] ---[ end trace 2530722966429f10 ]--- The warning in question was unnecessary but with Jeff's series the rules are also clearer. This patch removes the warning and updates the comment to explain why sk_mem_reclaim() may still be called. [jlayton: remove if (sk->sk_forward_alloc) conditional. As Leon points out that it's not needed.] Cc: Leon Romanovsky <leon@leon.nu> Signed-off-by: Mel Gorman <mgorman@suse.de> Signed-off-by: Jeff Layton <jeff.layton@primarydata.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2015-06-10 23:02:31 -07:00
..
datagram.c	new helper: msg_data_left()	2015-04-11 15:53:35 -04:00
dev_addr_lists.c	net: fix spelling for synchronized	2014-11-18 15:26:32 -05:00
dev_ioctl.c	dev_ioctl: use sizeof(x) instead of sizeof x	2014-11-18 15:27:32 -05:00
dev.c	net: replace last open coded skb_orphan_frags with function call	2015-06-08 12:15:13 -07:00
drop_monitor.c	net: Replace get_cpu_var through this_cpu_ptr	2014-08-26 13:45:47 -04:00
dst.c	dst: no need to take reference on DST_NOCACHE dsts	2014-12-09 16:08:17 -05:00
ethtool.c	Revert "net: core: 'ethtool' issue with querying phy settings"	2015-06-01 14:43:50 -07:00
fib_rules.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2015-04-06 22:34:15 -04:00
filter.c	bpf: fix bpf helpers to use skb->mac_header relative offsets	2015-04-16 14:08:49 -04:00
flow_dissector.c	xps: fix xps for stacked devices	2015-02-04 13:02:54 -08:00
flow.c	flowcache: Fix kernel panic in flow_cache_flush_task	2015-02-05 14:38:53 -08:00
gen_estimator.c	net: sched: make bstats per cpu and estimator RCU safe	2014-09-30 01:02:26 -04:00
gen_stats.c	gen_stats.c: Duplicate xstats buffer for later use	2015-02-19 15:45:53 -05:00
link_watch.c	dev: introduce dev_get_iflink()	2015-04-02 14:04:59 -04:00
Makefile	net: bury net/core/iovec.c - nothing in there is used anymore	2015-02-04 01:34:15 -05:00
neighbour.c	net: neighbour: Add mcast_resolicit to configure the number of multicast resolicitations in PROBE state.	2015-03-20 21:47:40 -04:00
net_namespace.c	netns: return RTM_NEWNSID instead of RTM_GETNSID on a get	2015-05-12 18:53:25 -04:00
net-procfs.c
net-sysfs.c	dev: introduce dev_get_iflink()	2015-04-02 14:04:59 -04:00
net-sysfs.h
net-traces.c
netclassid_cgroup.c	cgroup: rename cgroup_subsys->base_cftypes to ->legacy_cftypes	2014-07-15 11:05:09 -04:00
netevent.c
netpoll.c	net: rename vlan_tx_* helpers since "tx" is misleading there	2015-01-13 17:51:08 -05:00
netprio_cgroup.c	cgroup: rename cgroup_subsys->base_cftypes to ->legacy_cftypes	2014-07-15 11:05:09 -04:00
pktgen.c	net: pktgen: disable xmit_clone on virtual devices	2015-02-22 22:43:20 -05:00
ptp_classifier.c	net: filter: split 'struct sk_filter' into socket and bpf parts	2014-08-02 15:03:58 -07:00
request_sock.c	net: convert syn_wait_lock to a spinlock	2015-03-23 16:52:26 -04:00
rtnetlink.c	rtnl/bond: don't send rtnl msg for unregistered iface	2015-05-17 22:43:07 -04:00
scm.c	net: introduce helper macro for_each_cmsghdr	2014-12-10 22:41:55 -05:00
secure_seq.c	net: use ktime_get_ns() and ktime_get_real_ns() helpers	2014-08-22 19:57:23 -07:00
skbuff.c	net: fix crash in build_skb()	2015-04-25 15:49:49 -04:00
sock_diag.c	net: add real socket cookies	2015-03-11 21:55:28 -04:00
sock.c	net, swap: Remove a warning and clarify why sk_mem_reclaim is required when deactivating swap	2015-06-10 23:02:31 -07:00
stream.c
sysctl_net_core.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2015-03-20 18:51:09 -04:00
timestamping.c	net-timestamp: Make the clone operation stand-alone from phy timestamping	2014-09-05 17:43:45 -07:00
tso.c	net: tso: fix unaligned access to crafted TCP header in helper API	2014-10-22 12:52:55 -04:00
utils.c	net: Convert LIMIT_NETDEBUG to net_dbg_ratelimited	2014-11-11 14:10:31 -05:00