Daeho Jeong db6129f6ad f2fs: fix race of pending_pages in decompression ... [ Upstream commit 6422a71ef40e4751d59b8c9412e7e2dafe085878 ] I found out f2fs_free_dic() is invoked in a wrong timing, but f2fs_verify_bio() still needed the dic info and it triggered the below kernel panic. It has been caused by the race condition of pending_pages value between decompression and verity logic, when the same compression cluster had been split in different bios. By split bios, f2fs_verify_bio() ended up with decreasing pending_pages value before it is reset to nr_cpages by f2fs_decompress_pages() and caused the kernel panic. [ 4416.564763] Unable to handle kernel NULL pointer dereference at virtual address 0000000000000000 ... [ 4416.896016] Workqueue: fsverity_read_queue f2fs_verity_work [ 4416.908515] pc : fsverity_verify_page+0x20/0x78 [ 4416.913721] lr : f2fs_verify_bio+0x11c/0x29c [ 4416.913722] sp : ffffffc019533cd0 [ 4416.913723] x29: ffffffc019533cd0 x28: 0000000000000402 [ 4416.913724] x27: 0000000000000001 x26: 0000000000000100 [ 4416.913726] x25: 0000000000000001 x24: 0000000000000004 [ 4416.913727] x23: 0000000000001000 x22: 0000000000000000 [ 4416.913728] x21: 0000000000000000 x20: ffffffff2076f9c0 [ 4416.913729] x19: ffffffff2076f9c0 x18: ffffff8a32380c30 [ 4416.913731] x17: ffffffc01f966d97 x16: 0000000000000298 [ 4416.913732] x15: 0000000000000000 x14: 0000000000000000 [ 4416.913733] x13: f074faec89ffffff x12: 0000000000000000 [ 4416.913734] x11: 0000000000001000 x10: 0000000000001000 [ 4416.929176] x9 : ffffffff20d1f5c7 x8 : 0000000000000000 [ 4416.929178] x7 : 626d7464ff286b6b x6 : ffffffc019533ade [ 4416.929179] x5 : 000000008049000e x4 : ffffffff2793e9e0 [ 4416.929180] x3 : 000000008049000e x2 : ffffff89ecfa74d0 [ 4416.929181] x1 : 0000000000000c40 x0 : ffffffff2076f9c0 [ 4416.929184] Call trace: [ 4416.929187] fsverity_verify_page+0x20/0x78 [ 4416.929189] f2fs_verify_bio+0x11c/0x29c [ 4416.929192] f2fs_verity_work+0x58/0x84 [ 4417.050667] process_one_work+0x270/0x47c [ 4417.055354] worker_thread+0x27c/0x4d8 [ 4417.059784] kthread+0x13c/0x320 [ 4417.063693] ret_from_fork+0x10/0x18 Chao pointed this can happen by the below race condition. Thread A f2fs_post_read_wq fsverity_wq - f2fs_read_multi_pages() - f2fs_alloc_dic - dic->pending_pages = 2 - submit_bio() - submit_bio() - f2fs_post_read_work() handle first bio - f2fs_decompress_work() - __read_end_io() - f2fs_decompress_pages() - dic->pending_pages-- - enqueue f2fs_verity_work() - f2fs_verity_work() handle first bio - f2fs_verify_bio() - dic->pending_pages-- - f2fs_post_read_work() handle second bio - f2fs_decompress_work() - enqueue f2fs_verity_work() - f2fs_verify_pages() - f2fs_free_dic() - f2fs_verity_work() handle second bio - f2fs_verfy_bio() - use-after-free on dic Signed-off-by: Daeho Jeong <daehojeong@google.com> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>		2021-01-06 14:56:54 +01:00
..
acl.c	f2fs: clean up kvfree	2020-09-14 11:15:37 -07:00
acl.h	f2fs: Use the correct style for SPDX License Identifier	2020-05-08 06:55:55 -07:00
checkpoint.c	f2fs: avoid race condition for shrinker count	2021-01-06 14:56:54 +01:00
compress.c	f2fs: fix race of pending_pages in decompression	2021-01-06 14:56:54 +01:00
data.c	f2fs: fix race of pending_pages in decompression	2021-01-06 14:56:54 +01:00
debug.c	f2fs: avoid race condition for shrinker count	2021-01-06 14:56:54 +01:00
dir.c	f2fs-for-5.10-rc1	2020-10-16 15:14:43 -07:00
extent_cache.c	f2fs: support 64-bits key in f2fs rb-tree node entry	2020-09-10 14:03:30 -07:00
f2fs.h	f2fs: fix race of pending_pages in decompression	2021-01-06 14:56:54 +01:00
file.c	f2fs: fix to seek incorrect data offset in inline data file	2020-12-26 16:02:42 +01:00
gc.c	f2fs: clean up kvfree	2020-09-14 11:15:37 -07:00
gc.h	f2fs: support age threshold based garbage collection	2020-09-11 11:11:15 -07:00
hash.c	f2fs-for-5.8-rc1	2020-06-09 11:28:59 -07:00
inline.c	f2fs: clean up kvfree	2020-09-14 11:15:37 -07:00
inode.c	f2fs: fix to set SBI_NEED_FSCK flag for inconsistent inode	2020-10-09 10:29:31 -07:00
Kconfig	f2fs: compress: support lzo-rle compress algorithm	2020-05-11 20:36:46 -07:00
Makefile	f2fs: support data compression	2020-01-17 16:48:07 -08:00
namei.c	f2fs-for-5.10-rc1	2020-10-16 15:14:43 -07:00
node.c	f2fs: avoid race condition for shrinker count	2021-01-06 14:56:54 +01:00
node.h	f2fs: avoid race condition for shrinker count	2021-01-06 14:56:54 +01:00
recovery.c	f2fs: fix error path in do_recover_data()	2020-07-08 10:11:19 -07:00
segment.c	f2fs: init dirty_secmap incorrectly	2020-12-26 16:02:42 +01:00
segment.h	f2fs: fix wrong total_sections check and fsmeta check	2020-09-29 01:48:34 -07:00
shrinker.c	f2fs: avoid race condition for shrinker count	2021-01-06 14:56:54 +01:00
super.c	f2fs: fix shift-out-of-bounds in sanity_check_raw_super()	2021-01-06 14:56:52 +01:00
sysfs.c	f2fs: wait for sysfs kobject removal before freeing f2fs_sb_info	2020-10-14 13:23:30 -07:00
trace.c
trace.h	f2fs: Use the correct style for SPDX License Identifier	2020-05-08 06:55:55 -07:00
verity.c	mm/readahead: make page_cache_ra_unbounded take a readahead_control	2020-10-16 11:11:16 -07:00
xattr.c	f2fs: clean up kvfree	2020-09-14 11:15:37 -07:00
xattr.h	f2fs: code cleanup by removing ifdef macro surrounding	2020-05-26 18:56:10 -07:00