Alexey Dobriyan 891e6a9312 [ROSE]: Fix rose.ko oops on unload ... Commit a3d384029a aka "[AX.25]: Fix unchecked rose_add_loopback_neigh uses" transformed rose_loopback_neigh var into statically allocated one. However, on unload it will be kfree's which can't work. Steps to reproduce: modprobe rose rmmod rose BUG: unable to handle kernel NULL pointer dereference at virtual address 00000008 printing eip: c014c664 *pde = 00000000 Oops: 0000 [#1] PREEMPT DEBUG_PAGEALLOC Modules linked in: rose ax25 fan ufs loop usbhid rtc snd_intel8x0 snd_ac97_codec ehci_hcd ac97_bus uhci_hcd thermal usbcore button processor evdev sr_mod cdrom CPU: 0 EIP: 0060:[<c014c664>] Not tainted VLI EFLAGS: 00210086 (2.6.23-rc9 #3) EIP is at kfree+0x48/0xa1 eax: 00000556 ebx: c1734aa0 ecx: f6a5e000 edx: f7082000 esi: 00000000 edi: f9a55d20 ebp: 00200287 esp: f6a5ef28 ds: 007b es: 007b fs: 0000 gs: 0033 ss: 0068 Process rmmod (pid: 1823, ti=f6a5e000 task=f7082000 task.ti=f6a5e000) Stack: f9a55d20 f9a5200c 00000000 00000000 00000000 f6a5e000 f9a5200c f9a55a00 00000000 bf818cf0 f9a51f3f f9a55a00 00000000 c0132c60 65736f72 00000000 f69f9630 f69f9528 c014244a f6a4e900 00200246 f7082000 c01025e6 00000000 Call Trace: [<f9a5200c>] rose_rt_free+0x1d/0x49 [rose] [<f9a5200c>] rose_rt_free+0x1d/0x49 [rose] [<f9a51f3f>] rose_exit+0x4c/0xd5 [rose] [<c0132c60>] sys_delete_module+0x15e/0x186 [<c014244a>] remove_vma+0x40/0x45 [<c01025e6>] sysenter_past_esp+0x8f/0x99 [<c012bacf>] trace_hardirqs_on+0x118/0x13b [<c01025b6>] sysenter_past_esp+0x5f/0x99 ======================= Code: 05 03 1d 80 db 5b c0 8b 03 25 00 40 02 00 3d 00 40 02 00 75 03 8b 5b 0c 8b 73 10 8b 44 24 18 89 44 24 04 9c 5d fa e8 77 df fd ff <8b> 56 08 89 f8 e8 84 f4 fd ff e8 bd 32 06 00 3b 5c 86 60 75 0f EIP: [<c014c664>] kfree+0x48/0xa1 SS:ESP 0068:f6a5ef28 Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2007-10-07 23:44:17 -07:00
..
9p	9p: Reorganization of 9p file system code	2007-07-14 15:13:40 -05:00
bluetooth	[BLUETOOTH] l2cap: endianness annotations	2007-07-31 02:28:07 -07:00
irda	[IrDA]: Netlink layer.	2007-07-10 22:16:43 -07:00
iucv	[AF_IUCV]: Add lock when updating accept_q	2007-07-14 19:04:25 -07:00
netfilter	[NETFILTER]: nf_nat: add symbolic dependency on IPv4 conntrack	2007-08-07 18:12:01 -07:00
sctp	fix sctp_del_bind_addr() last argument type	2007-09-26 09:22:04 -07:00
tc_act
tipc	[TIPC]: Optimize stream send routine to avoid fragmentation	2007-07-10 22:06:12 -07:00
act_api.h	[NET_SCHED]: Kill CONFIG_NET_CLS_POLICE	2007-07-15 00:03:05 -07:00
addrconf.h	[IPV6] MIP6: Loadable module support for MIPv6.	2007-07-10 22:15:42 -07:00
af_rxrpc.h
af_unix.h	[AF_UNIX]: Make code static.	2007-07-31 02:28:27 -07:00
ah.h
arp.h
atmclip.h
ax25.h
ax88796.h	AX88796 network driver	2007-07-10 12:41:08 -04:00
cfg80211.h	[PATCH] cfg80211: Radiotap parser	2007-07-12 16:07:24 -04:00
checksum.h
cipso_ipv4.h	[NetLabel]: consolidate the struct socket/sock handling to just struct sock	2007-06-08 13:33:09 -07:00
compat.h
datalink.h
dn_dev.h
dn_fib.h
dn_neigh.h
dn_nsp.h
dn_route.h
dn.h	[DECNET]: Another unnecessary net/tcp.h inclusion in net/dn.h	2007-07-10 23:02:12 -07:00
dsfield.h
dst.h	[IPV4]: The scheduled removal of multipath cached routing support.	2007-07-10 22:05:57 -07:00
esp.h
fib_rules.h	[NETLINK]: Mark netlink policies const	2007-06-07 13:40:10 -07:00
flow.h	[IPV6] MIP6: Kill unnecessary ifdefs.	2007-07-10 22:15:41 -07:00
gen_stats.h
genetlink.h	[GENETLINK]: Dynamic multicast groups.	2007-07-18 15:47:52 -07:00
icmp.h
ieee80211_crypt.h	[PATCH] Update my email address from jkmaline@cc.hut.fi to j@w1.fi	2007-04-28 11:01:01 -04:00
ieee80211_radiotap.h	[PATCH] Remove comment about IEEE80211_RADIOTAP_FCS	2007-04-28 11:01:03 -04:00
ieee80211.h	[PATCH] ieee80211: add ieee80211_channel_to_freq	2007-05-08 11:51:59 -04:00
ieee80211softmac_wx.h
ieee80211softmac.h
if_inet6.h
inet6_connection_sock.h
inet6_hashtables.h
inet_common.h
inet_connection_sock.h
inet_ecn.h
inet_hashtables.h
inet_sock.h
inet_timewait_sock.h	[INET_SOCK]: make net/ipv4/inet_timewait_sock.c:__inet_twsk_kill() static	2007-07-14 19:00:59 -07:00
inetpeer.h
ip6_checksum.h
ip6_fib.h
ip6_route.h
ip6_tunnel.h
ip_fib.h	[IPV4]: The scheduled removal of multipath cached routing support.	2007-07-10 22:05:57 -07:00
ip_vs.h
ip.h	[TCP]: Honour sk_bound_dev_if in tcp_v4_send_ack	2007-06-07 13:38:51 -07:00
ipcomp.h
ipconfig.h
ipip.h
ipv6.h	[IPV6]: Remove circular dependency on if_inet6.h	2007-07-31 02:28:17 -07:00
ipx.h
iw_handler.h	[WEXT]: Clean up how wext is called.	2007-04-26 20:43:56 -07:00
lapb.h
llc_c_ac.h
llc_c_ev.h
llc_c_st.h
llc_conn.h
llc_if.h
llc_pdu.h
llc_s_ac.h
llc_s_ev.h
llc_s_st.h
llc_sap.h
llc.h
mac80211.h	[PATCH] mac80211: clarify some mac80211 things	2007-07-12 16:07:26 -04:00
mip6.h	[IPV6] MIP6: Loadable module support for MIPv6.	2007-07-10 22:15:42 -07:00
ndisc.h
neighbour.h
netdma.h
netevent.h
netlabel.h	SELinux: restore proper NetLabel caching behavior	2007-08-02 11:52:21 -04:00
netlink.h	[NETLINK]: attr: add nested compat attribute type	2007-07-10 22:15:38 -07:00
netrom.h
nexthop.h
p8022.h
pkt_cls.h	[NET_SCHED]: Kill CONFIG_NET_CLS_POLICE	2007-07-15 00:03:05 -07:00
pkt_sched.h	[NET_SCHED]: act_api: qdisc internal reclassify support	2007-07-15 00:02:31 -07:00
protocol.h
psnap.h
raw.h
rawv6.h	[IPV6] MIP6: Loadable module support for MIPv6.	2007-07-10 22:15:42 -07:00
red.h
request_sock.h
rose.h	[ROSE]: Fix rose.ko oops on unload	2007-10-07 23:44:17 -07:00
route.h	[IPV4]: Make ip_tos2prio const.	2007-07-10 22:19:04 -07:00
rtnetlink.h	[RTNETLINK]: Link creation API	2007-07-10 22:14:20 -07:00
sch_generic.h	[NET_SCHED]: Kill CONFIG_NET_CLS_POLICE	2007-07-15 00:03:05 -07:00
scm.h	avoid OPEN_MAX in SCM_MAX_FD	2007-07-17 10:23:03 -07:00
slhc_vj.h
snmp.h
sock.h	[SOCK]: Shrink struct sock by 8 bytes on 64-bit.	2007-05-31 01:23:32 -07:00
syncppp.h
tcp_ecn.h
tcp_states.h
tcp.h	[TCP]: Fix MD5 signature handling on big-endian.	2007-09-28 15:18:35 -07:00
timewait_sock.h
transp_v6.h
udp.h	[UDP]: Revert 2-pass hashing changes.	2007-06-07 13:40:50 -07:00
udplite.h	[UDP]: Revert 2-pass hashing changes.	2007-06-07 13:40:50 -07:00
wext.h	[NET]: Fix networking compilation errors	2007-04-27 15:31:24 -07:00
wireless.h
x25.h
x25device.h
xfrm.h	[XFRM]: Fix crash introduced by struct dst_entry reordering	2007-07-18 01:55:52 -07:00