6169a5cfaa
[ Upstream commit c5e6ae563c802c4d828d42e134af64004db2e58c ]
If you run 'make uImage uImage.gz' with the parallel option, uImage.gz
will be created by two threads simultaneously.
This is because arch/arc/Makefile does not specify the dependency
between uImage and uImage.gz. Hence, GNU Make assumes they can be
built in parallel. One thread descends into arch/arc/boot/ to create
uImage, and another to create uImage.gz.
Please notice the same log is displayed twice in the following steps:
$ export CROSS_COMPILE=<your-arc-compiler-prefix>
$ make -s ARCH=arc defconfig
$ make -j$(nproc) ARCH=arc uImage uImage.gz
[ snip ]
LD vmlinux
SORTTAB vmlinux
SYSMAP System.map
OBJCOPY arch/arc/boot/vmlinux.bin
OBJCOPY arch/arc/boot/vmlinux.bin
GZIP arch/arc/boot/vmlinux.bin.gz
GZIP arch/arc/boot/vmlinux.bin.gz
UIMAGE arch/arc/boot/uImage.gz
UIMAGE arch/arc/boot/uImage.gz
Image Name: Linux-5.10.0-rc4-00003-g62f23044
Created: Sun Nov 22 02:52:26 2020
Image Type: ARC Linux Kernel Image (gzip compressed)
Data Size: 2109376 Bytes = 2059.94 KiB = 2.01 MiB
Load Address: 80000000
Entry Point: 80004000
Image arch/arc/boot/uImage is ready
Image Name: Linux-5.10.0-rc4-00003-g62f23044
Created: Sun Nov 22 02:52:26 2020
Image Type: ARC Linux Kernel Image (gzip compressed)
Data Size: 2815455 Bytes = 2749.47 KiB = 2.69 MiB
Load Address: 80000000
Entry Point: 80004000
This is a race between the two threads trying to write to the same file
arch/arc/boot/uImage.gz. This is a potential problem that can generate
a broken file.
I fixed a similar problem for ARM by commit 3939f33450 ("ARM: 8418/1:
add boot image dependencies to not generate invalid images").
I highly recommend to avoid such build rules that cause a race condition.
Move the uImage rule to arch/arc/Makefile.
Another strangeness is that arch/arc/boot/Makefile compares the
timestamps between $(obj)/uImage and $(obj)/uImage.*:
$(obj)/uImage: $(obj)/uImage.$(suffix-y)
@ln -sf $(notdir $<) $@
@echo ' Image $@ is ready'
This does not work as expected since $(obj)/uImage is a symlink.
The symlink should be created in a phony target rule.
I used $(kecho) instead of echo to suppress the message
'Image arch/arc/boot/uImage is ready' when the -s option is given.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Signed-off-by: Vineet Gupta <vgupta@synopsys.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
124 lines
3.5 KiB
Makefile
124 lines
3.5 KiB
Makefile
# SPDX-License-Identifier: GPL-2.0-only
|
|
#
|
|
# Copyright (C) 2004, 2007-2010, 2011-2012 Synopsys, Inc. (www.synopsys.com)
|
|
#
|
|
|
|
KBUILD_DEFCONFIG := haps_hs_smp_defconfig
|
|
|
|
ifeq ($(CROSS_COMPILE),)
|
|
CROSS_COMPILE := $(call cc-cross-prefix, arc-linux- arceb-linux-)
|
|
endif
|
|
|
|
cflags-y += -fno-common -pipe -fno-builtin -mmedium-calls -D__linux__
|
|
|
|
tune-mcpu-def-$(CONFIG_ISA_ARCOMPACT) := -mcpu=arc700
|
|
tune-mcpu-def-$(CONFIG_ISA_ARCV2) := -mcpu=hs38
|
|
|
|
ifeq ($(CONFIG_ARC_TUNE_MCPU),"")
|
|
cflags-y += $(tune-mcpu-def-y)
|
|
else
|
|
tune-mcpu := $(shell echo $(CONFIG_ARC_TUNE_MCPU))
|
|
tune-mcpu-ok := $(call cc-option-yn, $(tune-mcpu))
|
|
ifeq ($(tune-mcpu-ok),y)
|
|
cflags-y += $(tune-mcpu)
|
|
else
|
|
# The flag provided by 'CONFIG_ARC_TUNE_MCPU' option isn't known by this compiler
|
|
# (probably the compiler is too old). Use ISA default mcpu flag instead as a safe option.
|
|
$(warning ** WARNING ** CONFIG_ARC_TUNE_MCPU flag '$(tune-mcpu)' is unknown, fallback to '$(tune-mcpu-def-y)')
|
|
cflags-y += $(tune-mcpu-def-y)
|
|
endif
|
|
endif
|
|
|
|
|
|
ifdef CONFIG_ARC_CURR_IN_REG
|
|
# For a global register defintion, make sure it gets passed to every file
|
|
# We had a customer reported bug where some code built in kernel was NOT using
|
|
# any kernel headers, and missing the r25 global register
|
|
# Can't do unconditionally because of recursive include issues
|
|
# due to <linux/thread_info.h>
|
|
LINUXINCLUDE += -include $(srctree)/arch/arc/include/asm/current.h
|
|
endif
|
|
|
|
cflags-y += -fsection-anchors
|
|
|
|
cflags-$(CONFIG_ARC_HAS_LLSC) += -mlock
|
|
cflags-$(CONFIG_ARC_HAS_SWAPE) += -mswape
|
|
|
|
ifdef CONFIG_ISA_ARCV2
|
|
|
|
ifdef CONFIG_ARC_USE_UNALIGNED_MEM_ACCESS
|
|
cflags-y += -munaligned-access
|
|
else
|
|
cflags-y += -mno-unaligned-access
|
|
endif
|
|
|
|
ifndef CONFIG_ARC_HAS_LL64
|
|
cflags-y += -mno-ll64
|
|
endif
|
|
|
|
ifndef CONFIG_ARC_HAS_DIV_REM
|
|
cflags-y += -mno-div-rem
|
|
endif
|
|
|
|
endif
|
|
|
|
cfi := $(call as-instr,.cfi_startproc\n.cfi_endproc,-DARC_DW2_UNWIND_AS_CFI)
|
|
cflags-$(CONFIG_ARC_DW2_UNWIND) += -fasynchronous-unwind-tables $(cfi)
|
|
|
|
# small data is default for elf32 tool-chain. If not usable, disable it
|
|
# This also allows repurposing GP as scratch reg to gcc reg allocator
|
|
disable_small_data := y
|
|
cflags-$(disable_small_data) += -mno-sdata -fcall-used-gp
|
|
|
|
cflags-$(CONFIG_CPU_BIG_ENDIAN) += -mbig-endian
|
|
ldflags-$(CONFIG_CPU_BIG_ENDIAN) += -EB
|
|
|
|
LIBGCC = $(shell $(CC) $(cflags-y) --print-libgcc-file-name)
|
|
|
|
# Modules with short calls might break for calls into builtin-kernel
|
|
KBUILD_CFLAGS_MODULE += -mlong-calls -mno-millicode
|
|
|
|
# Finally dump eveything into kernel build system
|
|
KBUILD_CFLAGS += $(cflags-y)
|
|
KBUILD_AFLAGS += $(KBUILD_CFLAGS)
|
|
KBUILD_LDFLAGS += $(ldflags-y)
|
|
|
|
head-y := arch/arc/kernel/head.o
|
|
|
|
# See arch/arc/Kbuild for content of core part of the kernel
|
|
core-y += arch/arc/
|
|
|
|
# w/o this dtb won't embed into kernel binary
|
|
core-y += arch/arc/boot/dts/
|
|
|
|
core-y += arch/arc/plat-sim/
|
|
core-$(CONFIG_ARC_PLAT_TB10X) += arch/arc/plat-tb10x/
|
|
core-$(CONFIG_ARC_PLAT_AXS10X) += arch/arc/plat-axs10x/
|
|
core-$(CONFIG_ARC_SOC_HSDK) += arch/arc/plat-hsdk/
|
|
|
|
drivers-$(CONFIG_OPROFILE) += arch/arc/oprofile/
|
|
|
|
libs-y += arch/arc/lib/ $(LIBGCC)
|
|
|
|
boot := arch/arc/boot
|
|
|
|
boot_targets := uImage.bin uImage.gz uImage.lzma
|
|
|
|
PHONY += $(boot_targets)
|
|
$(boot_targets): vmlinux
|
|
$(Q)$(MAKE) $(build)=$(boot) $(boot)/$@
|
|
|
|
uimage-default-y := uImage.bin
|
|
uimage-default-$(CONFIG_KERNEL_GZIP) := uImage.gz
|
|
uimage-default-$(CONFIG_KERNEL_LZMA) := uImage.lzma
|
|
|
|
PHONY += uImage
|
|
uImage: $(uimage-default-y)
|
|
@ln -sf $< $(boot)/uImage
|
|
@$(kecho) ' Image $(boot)/uImage is ready'
|
|
|
|
CLEAN_FILES += $(boot)/uImage
|
|
|
|
archclean:
|
|
$(Q)$(MAKE) $(clean)=$(boot)
|