Eric Dumazet 3fb07daff8 ipv4: add reference counting to metrics ... Andrey Konovalov reported crashes in ipv4_mtu() I could reproduce the issue with KASAN kernels, between 10.246.7.151 and 10.246.7.152 : 1) 20 concurrent netperf -t TCP_RR -H 10.246.7.152 -l 1000 & 2) At the same time run following loop : while : do ip ro add 10.246.7.152 dev eth0 src 10.246.7.151 mtu 1500 ip ro del 10.246.7.152 dev eth0 src 10.246.7.151 mtu 1500 done Cong Wang attempted to add back rt->fi in commit 82486aa6f1 ("ipv4: restore rt->fi for reference counting") but this proved to add some issues that were complex to solve. Instead, I suggested to add a refcount to the metrics themselves, being a standalone object (in particular, no reference to other objects) I tried to make this patch as small as possible to ease its backport, instead of being super clean. Note that we believe that only ipv4 dst need to take care of the metric refcount. But if this is wrong, this patch adds the basic infrastructure to extend this to other families. Many thanks to Julian Anastasov for reviewing this patch, and Cong Wang for his efforts on this problem. Fixes: 2860583fe8 ("ipv4: Kill rt->fi") Signed-off-by: Eric Dumazet <edumazet@google.com> Reported-by: Andrey Konovalov <andreyknvl@google.com> Reviewed-by: Julian Anastasov <ja@ssi.bg> Acked-by: Cong Wang <xiyou.wangcong@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2017-05-26 14:57:07 -04:00
..
9p
bluetooth	Bluetooth: L2CAP: Fix L2CAP_CR_SCID_IN_USE value	2017-04-12 22:02:37 +02:00
caif
irda	scripts/spelling.txt: add "overide" pattern and fix typo instances	2017-03-09 17:01:09 -08:00
iucv
netfilter	netfilter: nf_tables: revisit chain/object refcounting from elements	2017-05-15 12:51:41 +02:00
netns	can: network namespace support for CAN gateway	2017-04-25 09:04:30 +02:00
nfc	NFC: Add nfc_dbg() macro	2017-04-05 10:15:20 +02:00
phonet
sctp	sctp: process duplicated strreset out and addstrm out requests correctly	2017-04-18 13:39:50 -04:00
tc_act	net/sched: act_csum: Add accessors for offloading drivers	2017-05-23 16:23:31 +03:00
6lowpan.h	6lowpan: Fix IID format for Bluetooth	2017-04-12 22:02:36 +02:00
act_api.h
addrconf.h	ipv6: reorder ip6_route_dev_notifier after ipv6_dev_notf	2017-05-08 17:31:24 -04:00
af_ieee802154.h
af_rxrpc.h	rxrpc: Note a successfully aborted kernel operation	2017-04-06 10:11:59 +01:00
af_unix.h
af_vsock.h	VSOCK: Add vsockmon tap functions	2017-04-24 12:35:56 -04:00
ah.h
arp.h
atmclip.h
ax25.h
ax88796.h
bond_3ad.h
bond_alb.h
bond_options.h
bonding.h	bonding: fix wq initialization for links created via netlink	2017-04-21 15:28:37 -04:00
busy_poll.h	net: Commonize busy polling code to focus on napi_id instead of socket	2017-03-24 20:49:31 -07:00
calipso.h
cfg80211-wext.h
cfg80211.h	cfg80211: fix multi scheduled scan kernel-doc	2017-05-08 13:09:38 +02:00
cfg802154.h
checksum.h
cipso_ipv4.h
cls_cgroup.h
codel_impl.h
codel_qdisc.h
codel.h
compat.h
datalink.h
dcbevent.h
dcbnl.h
devlink.h	net/devlink: Add E-Switch encapsulation control	2017-04-22 20:26:37 +03:00
dn_dev.h
dn_fib.h
dn_neigh.h
dn_nsp.h
dn_route.h
dn.h
dsa.h	net: dsa: add support for the SMSC-LAN9303 tagging format	2017-04-20 13:48:54 -04:00
dsfield.h
dst_cache.h
dst_metadata.h
dst_ops.h
dst.h	ipv4: add reference counting to metrics	2017-05-26 14:57:07 -04:00
esp.h	esp6: Reorganize esp_output	2017-04-14 10:06:42 +02:00
ethoc.h
fib_rules.h	net: rtnetlink: plumb extended ack to doit function	2017-04-17 15:35:38 -04:00
firewire.h
flow_dissector.h	flow_dissector: add mpls support (v2)	2017-04-24 14:30:46 -04:00
flow.h	flowcache: make flow_key_size() return "unsigned int"	2017-04-03 19:04:48 -07:00
flowcache.h	flowcache: more "unsigned int"	2017-04-03 19:04:48 -07:00
fou.h
fq_impl.h
fq.h
garp.h
gen_stats.h
genetlink.h	netlink: pass extended ACK struct to parsing functions	2017-04-13 13:58:22 -04:00
geneve.h
gre.h
gro_cells.h
gtp.h
gue.h
hwbm.h
icmp.h
ieee80211_radiotap.h
ieee802154_netdev.h
if_inet6.h
ife.h
ila.h
inet_common.h	net: Work around lockdep limitation in sockets that use sockets	2017-03-09 18:23:27 -08:00
inet_connection_sock.h	net: Work around lockdep limitation in sockets that use sockets	2017-03-09 18:23:27 -08:00
inet_ecn.h
inet_frag.h
inet_hashtables.h
inet_sock.h
inet_timewait_sock.h
inet6_connection_sock.h
inet6_hashtables.h
inetpeer.h
ip_fib.h	ipv4: add reference counting to metrics	2017-05-26 14:57:07 -04:00
ip_tunnels.h	ip_tunnel: Allow policy-based routing through tunnels	2017-04-21 13:21:31 -04:00
ip_vs.h	ipvs: remove unused function ip_vs_set_state_timeout	2017-04-28 12:00:10 +02:00
ip.h	net: ipv4: Refine the ipv4_default_advmss	2017-04-13 13:19:48 -04:00
ip6_checksum.h
ip6_fib.h
ip6_route.h	ipv6: initialize route null entry in addrconf_init()	2017-05-04 12:51:24 -04:00
ip6_tunnel.h	ip6_tunnel: Allow policy-based routing through tunnels	2017-04-21 13:21:30 -04:00
ipcomp.h
ipconfig.h
ipv6.h
ipx.h
iw_handler.h
kcm.h
l3mdev.h
lapb.h
lib80211.h
llc_c_ac.h
llc_c_ev.h
llc_c_st.h
llc_conn.h
llc_if.h
llc_pdu.h
llc_s_ac.h
llc_s_ev.h
llc_s_st.h
llc_sap.h
llc.h
lwtunnel.h
mac80211.h	mac80211: properly remove RX_ENC_FLAG_40MHZ	2017-05-08 11:11:56 +02:00
mac802154.h
mip6.h
mld.h
mpls_iptunnel.h	net: mpls: Increase max number of labels for lwt encap	2017-04-01 20:21:44 -07:00
mpls.h
mrp.h
ncsi.h
ndisc.h	ipv6: add support for NETDEV_RESEND_IGMP event	2017-03-28 22:02:21 -07:00
neighbour.h	net: neigh: make ->hh_len 32-bit	2017-04-12 13:59:21 -04:00
net_namespace.h	can: initial support for network namespaces	2017-04-04 17:35:58 +02:00
net_ratelimit.h
netevent.h
netlabel.h
netlink.h	netlink: pass extended ACK struct to parsing functions	2017-04-13 13:58:22 -04:00
netprio_cgroup.h
netrom.h
nexthop.h
nl802154.h
p8022.h
ping.h
pkt_cls.h	net/sched: Reflect HW offload status	2017-02-17 12:08:05 -05:00
pkt_sched.h	net: sched: make default fifo qdiscs appear in the dump	2017-03-12 22:53:02 -07:00
pptp.h
protocol.h	net: Add sysctl to toggle early demux for tcp and udp	2017-03-24 13:17:07 -07:00
psample.h
psnap.h
raw.h
rawv6.h
red.h
regulatory.h
request_sock.h
rose.h
route.h	Revert "ipv4: restore rt->fi for reference counting"	2017-05-08 22:35:32 -04:00
rtnetlink.h	net: rtnetlink: plumb extended ack to doit function	2017-04-17 15:35:38 -04:00
sch_generic.h	net_sched: move the empty tp check from ->destroy() to ->delete()	2017-04-21 13:58:15 -04:00
scm.h	sched/headers: Prepare to remove <linux/cred.h> inclusion from <linux/sched.h>	2017-03-02 08:42:31 +01:00
secure_seq.h	tcp: randomize timestamps on syncookies	2017-05-05 12:00:11 -04:00
seg6_hmac.h
seg6.h
slhc_vj.h
smc.h
snmp.h
sock_reuseport.h
sock.h	Merge branch 'core-rcu-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2017-05-10 10:30:46 -07:00
Space.h
stp.h
strparser.h
switchdev.h
tcp_states.h
tcp.h	tcp: make congestion control optionally skip slow start after idle	2017-05-08 14:37:07 -04:00
timewait_sock.h
transp_v6.h
tso.h
udp_tunnel.h
udp.h	net: Add sysctl to toggle early demux for tcp and udp	2017-03-24 13:17:07 -07:00
udplite.h
vsock_addr.h
vxlan.h
wext.h
wimax.h
x25.h	net: x25: fix one potential use-after-free issue	2017-05-18 10:05:40 -04:00
x25device.h
xfrm.h	xfrm: fix stack access out of bounds with CONFIG_XFRM_SUB_POLICY	2017-05-04 07:30:59 +02:00