luck/tmp_suning_uos_patched
1
0
Fork 1
Code Issues Pull Requests Packages Projects Releases Wiki Activity
6150c22e2a
tmp_suning_uos_patched/net/ipv4
History
Xiaoliang (David) Wei 6150c22e2a [TCP] tcp_highspeed: Fix AI updates. 
I think there is still a problem with the AIMD parameter update in
HighSpeed TCP code.

Line 125~138 of the code (net/ipv4/tcp_highspeed.c):

	/* Update AIMD parameters */
	if (tp->snd_cwnd > hstcp_aimd_vals[ca->ai].cwnd) {
		while (tp->snd_cwnd > hstcp_aimd_vals[ca->ai].cwnd &&
		       ca->ai < HSTCP_AIMD_MAX - 1)
			ca->ai++;
	} else if (tp->snd_cwnd < hstcp_aimd_vals[ca->ai].cwnd) {
		while (tp->snd_cwnd > hstcp_aimd_vals[ca->ai].cwnd &&
		       ca->ai > 0)
			ca->ai--;

In fact, the second part (decreasing ca->ai) never decreases since the
while loop's inequality is in the reverse direction. This leads to
unfairness with multiple flows (once a flow happens to enjoy a higher
ca->ai, it keeps enjoying that even its cwnd decreases)

Here is a tentative fix (I also added a comment, trying to keep the
change clear):

Acked-by: Stephen Hemminger <shemminger@osdl.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
2006-07-12 13:58:50 -07:00
..
ipvs Remove obsolete #include <linux/config.h> 2006-06-30 19:25:36 +02:00
netfilter Merge master.kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6 2006-06-30 15:40:17 -07:00
af_inet.c [NET] gso: Fix up GSO packets with broken checksums 2006-07-08 13:34:56 -07:00
ah4.c Remove obsolete #include <linux/config.h> 2006-06-30 19:25:36 +02:00
arp.c Remove obsolete #include <linux/config.h> 2006-06-30 19:25:36 +02:00
datagram.c Remove obsolete #include <linux/config.h> 2006-06-30 19:25:36 +02:00
devinet.c Remove obsolete #include <linux/config.h> 2006-06-30 19:25:36 +02:00
esp4.c Remove obsolete #include <linux/config.h> 2006-06-30 19:25:36 +02:00
fib_frontend.c Remove obsolete #include <linux/config.h> 2006-06-30 19:25:36 +02:00
fib_hash.c Remove obsolete #include <linux/config.h> 2006-06-30 19:25:36 +02:00
fib_lookup.h [IPV4]: Prepare FIB core for RCU. 2005-08-29 16:08:31 -07:00
fib_rules.c [NET]: Fix IPv4/DECnet routing rule dumping 2006-07-08 13:38:55 -07:00
fib_semantics.c Remove obsolete #include <linux/config.h> 2006-06-30 19:25:36 +02:00
fib_trie.c Remove obsolete #include <linux/config.h> 2006-06-30 19:25:36 +02:00
icmp.c Remove obsolete #include <linux/config.h> 2006-06-30 19:25:36 +02:00
igmp.c Remove obsolete #include <linux/config.h> 2006-06-30 19:25:36 +02:00
inet_connection_sock.c Remove obsolete #include <linux/config.h> 2006-06-30 19:25:36 +02:00
inet_diag.c Remove obsolete #include <linux/config.h> 2006-06-30 19:25:36 +02:00
inet_hashtables.c Remove obsolete #include <linux/config.h> 2006-06-30 19:25:36 +02:00
inet_timewait_sock.c Remove obsolete #include <linux/config.h> 2006-06-30 19:25:36 +02:00
inetpeer.c [IPV4] inetpeer: Get rid of volatile from peer_total 2006-07-10 14:50:30 -07:00
ip_forward.c Remove obsolete #include <linux/config.h> 2006-06-30 19:25:36 +02:00
ip_fragment.c Remove obsolete #include <linux/config.h> 2006-06-30 19:25:36 +02:00
ip_gre.c Remove obsolete #include <linux/config.h> 2006-06-30 19:25:36 +02:00
ip_input.c Remove obsolete #include <linux/config.h> 2006-06-30 19:25:36 +02:00
ip_options.c [IPV4]: ip_options_fragment() has no effect on fragmentation 2006-05-09 15:18:50 -07:00
ip_output.c [NET] gso: Add skb_is_gso 2006-07-08 13:34:32 -07:00
ip_sockglue.c Remove obsolete #include <linux/config.h> 2006-06-30 19:25:36 +02:00
ipcomp.c Remove obsolete #include <linux/config.h> 2006-06-30 19:25:36 +02:00
ipconfig.c [NET]: Convert RTNL to mutex. 2006-03-20 22:23:58 -08:00
ipip.c Remove obsolete #include <linux/config.h> 2006-06-30 19:25:36 +02:00
ipmr.c Remove obsolete #include <linux/config.h> 2006-06-30 19:25:36 +02:00
Kconfig [TCP]: Remove TCP Compound 2006-07-10 14:50:35 -07:00
Makefile [TCP]: Remove TCP Compound 2006-07-10 14:50:35 -07:00
multipath_drr.c Remove obsolete #include <linux/config.h> 2006-06-30 19:25:36 +02:00
multipath_random.c Remove obsolete #include <linux/config.h> 2006-06-30 19:25:36 +02:00
multipath_rr.c Remove obsolete #include <linux/config.h> 2006-06-30 19:25:36 +02:00
multipath_wrandom.c Remove obsolete #include <linux/config.h> 2006-06-30 19:25:36 +02:00
multipath.c Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
netfilter.c [NETFILTER]: Add address family specific checksum helpers 2006-04-09 22:25:41 -07:00
proc.c [PATCH] for_each_possible_cpu: network codes 2006-04-11 06:18:31 -07:00
protocol.c Remove obsolete #include <linux/config.h> 2006-06-30 19:25:36 +02:00
raw.c [IPV4]: Right prototype of __raw_v4_lookup() 2006-06-17 21:29:39 -07:00
route.c [PATCH] lockdep: fix RT_HASH_LOCK_SZ 2006-07-03 15:27:05 -07:00
syncookies.c [ICSK]: Rename struct tcp_func to struct inet_connection_sock_af_ops 2006-01-03 13:10:38 -08:00
sysctl_net_ipv4.c Remove obsolete #include <linux/config.h> 2006-06-30 19:25:36 +02:00
tcp_bic.c Remove obsolete #include <linux/config.h> 2006-06-30 19:25:36 +02:00
tcp_cong.c Remove obsolete #include <linux/config.h> 2006-06-30 19:25:36 +02:00
tcp_cubic.c Remove obsolete #include <linux/config.h> 2006-06-30 19:25:36 +02:00
tcp_diag.c Remove obsolete #include <linux/config.h> 2006-06-30 19:25:36 +02:00
tcp_highspeed.c [TCP] tcp_highspeed: Fix AI updates. 2006-07-12 13:58:50 -07:00
tcp_htcp.c Remove obsolete #include <linux/config.h> 2006-06-30 19:25:36 +02:00
tcp_hybla.c Remove obsolete #include <linux/config.h> 2006-06-30 19:25:36 +02:00
tcp_input.c Remove obsolete #include <linux/config.h> 2006-06-30 19:25:36 +02:00
tcp_ipv4.c [NET] gso: Fix up GSO packets with broken checksums 2006-07-08 13:34:56 -07:00
tcp_lp.c [TCP]: TCP Low Priority congestion control 2006-06-17 21:29:21 -07:00
tcp_minisocks.c [PATCH] lockdep: locking init debugging improvement 2006-07-03 15:27:02 -07:00
tcp_output.c [NET]: Generalise TSO-specific bits from skb_setup_caps 2006-06-30 14:12:08 -07:00
tcp_probe.c [TCP]: Fix compile warning in tcp_probe.c 2006-06-17 21:29:35 -07:00
tcp_scalable.c Remove obsolete #include <linux/config.h> 2006-06-30 19:25:36 +02:00
tcp_timer.c [TCP]: MTU probing 2006-03-20 17:53:41 -08:00
tcp_vegas.c Remove obsolete #include <linux/config.h> 2006-06-30 19:25:36 +02:00
tcp_veno.c [TCP]: Minimum congestion window consolidation. 2006-06-17 21:29:29 -07:00
tcp_westwood.c Remove obsolete #include <linux/config.h> 2006-06-30 19:25:36 +02:00
tcp.c [NET]: Verify gso_type too in gso_segment 2006-07-03 19:38:35 -07:00
tunnel4.c [INET]: Move no-tunnel ICMP error to tunnel4/tunnel6 2006-04-09 22:25:25 -07:00
udp.c Remove obsolete #include <linux/config.h> 2006-06-30 19:25:36 +02:00
xfrm4_input.c [IPSEC] xfrm: Abstract out encapsulation modes 2006-06-17 21:28:39 -07:00
xfrm4_mode_transport.c [IPSEC] proto: Move transport mode input path into xfrm_mode_transport 2006-06-17 21:28:41 -07:00
xfrm4_mode_tunnel.c [IPSEC] xfrm: Abstract out encapsulation modes 2006-06-17 21:28:39 -07:00
xfrm4_output.c [NET] gso: Add skb_is_gso 2006-07-08 13:34:32 -07:00
xfrm4_policy.c Remove obsolete #include <linux/config.h> 2006-06-30 19:25:36 +02:00
xfrm4_state.c [IPSEC] xfrm: Undo afinfo lock proliferation 2006-06-17 21:28:37 -07:00
xfrm4_tunnel.c [IPSEC]: Kill unused decap state argument 2006-04-01 00:52:46 -08:00