luck/tmp_suning_uos_patched
1
0
Fork 1
Code Issues Pull Requests Packages Projects Releases Wiki Activity
849be516c5
tmp_suning_uos_patched/drivers/i2c/busses
History
Jean Delvare 849be516c5 i2c-ali1563: Fix device initialization 
The i2c-ali1563 initialization looks quite broken to me:
* If the I/O space isn't enabled, we forcibly set 3 bits in
  the PCI configuration space instead of just the one enabling
  the I/O space.
* After that we pretend to check if the write worked, but we
  don't actually read the new value from the register.
* It's probably not a good idea to enable the I/O space if no
  base address has been set.

So I propose the following changes to that part of the driver:
* Merge ali1563_enable() into ali1563_setup().
* Check the base address before the I/O space enabled bit.

Signed-off-by: Jean Delvare <khali@linux-fr.org>
Acked-by: Rudolf Marek <r.marek@assembler.cz>
2007-02-13 22:08:57 +01:00
..
i2c-ali15x3.c i2c: Constify i2c_algorithm declarations, part 2 2006-09-26 15:38:52 -07:00
i2c-ali1535.c i2c: Constify i2c_algorithm declarations, part 2 2006-09-26 15:38:52 -07:00
i2c-ali1563.c i2c-ali1563: Fix device initialization 2007-02-13 22:08:57 +01:00
i2c-amd756-s4882.c [PATCH] I2C: i2c-amd756-s4882: Improve static mutex initialization 2006-03-23 14:21:54 -08:00
i2c-amd756.c i2c: Constify i2c_algorithm declarations, part 2 2006-09-26 15:38:52 -07:00
i2c-amd8111.c i2c: Constify i2c_algorithm declarations, part 2 2006-09-26 15:38:52 -07:00
i2c-at91.c i2c: New Atmel AT91 bus driver 2006-12-10 21:21:30 +01:00
i2c-au1550.c i2c: Constify i2c_algorithm declarations, part 2 2006-09-26 15:38:52 -07:00
i2c-au1550.h
i2c-elektor.c i2c: Discard the i2c algo del_bus wrappers 2006-12-10 21:21:33 +01:00
i2c-hydra.c i2c: Discard the i2c algo del_bus wrappers 2006-12-10 21:21:33 +01:00
i2c-i801.c i2c: Enable PEC on more i2c-i801 devices 2006-12-10 21:21:33 +01:00
i2c-i810.c i2c: Discard the i2c algo del_bus wrappers 2006-12-10 21:21:33 +01:00
i2c-ibm_iic.c i2c: Add request/release_mem_region to i2c-ibm_iic bus driver 2006-12-10 21:21:29 +01:00
i2c-ibm_iic.h fix file specification in comments 2006-10-03 23:01:26 +02:00
i2c-iop3xx.c IRQ: Maintain regs pointer globally rather than passing to IRQ handlers 2006-10-05 15:10:12 +01:00
i2c-iop3xx.h [PATCH] i2c-iop3xx: Avoid addressing self 2006-07-12 15:43:06 -07:00
i2c-isa.c hwmon: Let w83781d and lm78 load again 2006-10-18 13:03:09 -07:00
i2c-ixp4xx.c i2c: Discard the i2c algo del_bus wrappers 2006-12-10 21:21:33 +01:00
i2c-ixp2000.c i2c: Discard the i2c algo del_bus wrappers 2006-12-10 21:21:33 +01:00
i2c-mpc.c IRQ: Maintain regs pointer globally rather than passing to IRQ handlers 2006-10-05 15:10:12 +01:00
i2c-mv64xxx.c i2c-mv64xxx: Fix random oops at boot 2007-01-05 17:54:05 +01:00
i2c-nforce2.c i2c: Cleanups to the i2c-nforce2 bus driver 2006-12-10 21:21:29 +01:00
i2c-ocores.c IRQ: Maintain regs pointer globally rather than passing to IRQ handlers 2006-10-05 15:10:12 +01:00
i2c-omap.c i2c: Fix OMAP clock prescaler to match the comment 2006-12-10 21:21:34 +01:00
i2c-parport-light.c i2c: Discard the i2c algo del_bus wrappers 2006-12-10 21:21:33 +01:00
i2c-parport.c i2c: Discard the i2c algo del_bus wrappers 2006-12-10 21:21:33 +01:00
i2c-parport.h [PATCH] i2c-parport: Make type parameter mandatory 2006-04-14 11:18:34 -07:00
i2c-pca-isa.c i2c: Discard the i2c algo del_bus wrappers 2006-12-10 21:21:33 +01:00
i2c-piix4.c i2c: Constify i2c_algorithm declarations, part 2 2006-09-26 15:38:52 -07:00
i2c-pnx.c i2c-pnx: Fix interrupt handler, get rid of EARLY config option 2007-01-04 13:07:03 +01:00
i2c-powermac.c [POWERPC] Fix i2c-powermac platform device usage 2006-10-10 13:56:13 +10:00
i2c-prosavage.c i2c: Discard the i2c algo del_bus wrappers 2006-12-10 21:21:33 +01:00
i2c-pxa.c [ARM] Remove EEPROM slave emulation from i2c-pxa driver. 2006-11-30 12:24:45 +00:00
i2c-rpx.c IRQ: Maintain regs pointer globally rather than passing to IRQ handlers 2006-10-05 15:10:12 +01:00
i2c-s3c2410.c IRQ: Maintain regs pointer globally rather than passing to IRQ handlers 2006-10-05 15:10:12 +01:00
i2c-savage4.c i2c: Discard the i2c algo del_bus wrappers 2006-12-10 21:21:33 +01:00
i2c-sibyte.c [PATCH] i2c-sibyte: Fix modular build breakage 2006-09-29 09:34:17 -07:00
i2c-sis96x.c i2c: Constify i2c_algorithm declarations, part 2 2006-09-26 15:38:52 -07:00
i2c-sis630.c i2c: Constify i2c_algorithm declarations, part 2 2006-09-26 15:38:52 -07:00
i2c-sis5595.c i2c: Constify i2c_algorithm declarations, part 2 2006-09-26 15:38:52 -07:00
i2c-stub.c i2c: Constify i2c_algorithm declarations, part 2 2006-09-26 15:38:52 -07:00
i2c-versatile.c i2c: New ARM Versatile/Realview bus driver 2006-12-10 21:21:32 +01:00
i2c-via.c i2c: Discard the i2c algo del_bus wrappers 2006-12-10 21:21:33 +01:00
i2c-viapro.c i2c: Constify i2c_algorithm declarations, part 2 2006-09-26 15:38:52 -07:00
i2c-voodoo3.c i2c: Discard the i2c algo del_bus wrappers 2006-12-10 21:21:33 +01:00
Kconfig i2c-pnx: Fix interrupt handler, get rid of EARLY config option 2007-01-04 13:07:03 +01:00
Makefile i2c: New ARM Versatile/Realview bus driver 2006-12-10 21:21:32 +01:00
scx200_acb.c [PATCH] scx200_acb: handle PCI errors 2006-11-20 09:42:05 -08:00
scx200_i2c.c i2c: Discard the i2c algo del_bus wrappers 2006-12-10 21:21:33 +01:00