1e2c2a4fe4
The header files could not be build indepdent from each other. This is happened because headers didn't include the files for things they've used. This was problematic because the success of a build depended on the knowledge about the right order of local includes. Also source files were not including everything they've used explicitly. Instead they required that transitive includes are always stable. This is problematic because some transitive includes are not obvious, depend on config settings and may not be stable in the future. The order for include blocks are: * primary headers (main.h and the *.h file of a *.c file) * global linux headers * required local headers * extra forward declarations for pointers in function/struct declarations The only exceptions are linux/bitops.h and linux/if_ether.h in packet.h. This header file is shared with userspace applications like batctl and must therefore build together with userspace applications. The header linux/bitops.h is not part of the uapi headers and linux/if_ether.h conflicts with the musl implementation of netinet/if_ether.h. The maintainers rejected the use of __KERNEL__ preprocessor checks and thus these two headers are only in main.h. All files using packet.h first have to include main.h to work correctly. Reported-by: Markus Pargmann <mpa@pengutronix.de> Signed-off-by: Sven Eckelmann <sven@narfation.org> Signed-off-by: Marek Lindner <mareklindner@neomailbox.ch>
81 lines
1.9 KiB
C
81 lines
1.9 KiB
C
/* Copyright (C) 2006-2015 B.A.T.M.A.N. contributors:
|
|
*
|
|
* Simon Wunderlich, Marek Lindner
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of version 2 of the GNU General Public
|
|
* License as published by the Free Software Foundation.
|
|
*
|
|
* This program is distributed in the hope that it will be useful, but
|
|
* WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#include "hash.h"
|
|
#include "main.h"
|
|
|
|
#include <linux/fs.h>
|
|
#include <linux/lockdep.h>
|
|
#include <linux/slab.h>
|
|
|
|
/* clears the hash */
|
|
static void batadv_hash_init(struct batadv_hashtable *hash)
|
|
{
|
|
uint32_t i;
|
|
|
|
for (i = 0; i < hash->size; i++) {
|
|
INIT_HLIST_HEAD(&hash->table[i]);
|
|
spin_lock_init(&hash->list_locks[i]);
|
|
}
|
|
}
|
|
|
|
/* free only the hashtable and the hash itself. */
|
|
void batadv_hash_destroy(struct batadv_hashtable *hash)
|
|
{
|
|
kfree(hash->list_locks);
|
|
kfree(hash->table);
|
|
kfree(hash);
|
|
}
|
|
|
|
/* allocates and clears the hash */
|
|
struct batadv_hashtable *batadv_hash_new(uint32_t size)
|
|
{
|
|
struct batadv_hashtable *hash;
|
|
|
|
hash = kmalloc(sizeof(*hash), GFP_ATOMIC);
|
|
if (!hash)
|
|
return NULL;
|
|
|
|
hash->table = kmalloc_array(size, sizeof(*hash->table), GFP_ATOMIC);
|
|
if (!hash->table)
|
|
goto free_hash;
|
|
|
|
hash->list_locks = kmalloc_array(size, sizeof(*hash->list_locks),
|
|
GFP_ATOMIC);
|
|
if (!hash->list_locks)
|
|
goto free_table;
|
|
|
|
hash->size = size;
|
|
batadv_hash_init(hash);
|
|
return hash;
|
|
|
|
free_table:
|
|
kfree(hash->table);
|
|
free_hash:
|
|
kfree(hash);
|
|
return NULL;
|
|
}
|
|
|
|
void batadv_hash_set_lock_class(struct batadv_hashtable *hash,
|
|
struct lock_class_key *key)
|
|
{
|
|
uint32_t i;
|
|
|
|
for (i = 0; i < hash->size; i++)
|
|
lockdep_set_class(&hash->list_locks[i], key);
|
|
}
|