bb34f24c7d
We should not handle migrate lockres if we are already in
'DLM_CTXT_IN_SHUTDOWN', as that will cause lockres remains after leaving
dlm domain. At last other nodes will get stuck into infinite loop when
requsting lock from us.
The problem is caused by concurrency umount between nodes. Before
receiveing N1's DLM_BEGIN_EXIT_DOMAIN_MSG, N2 has picked up N1 as the
migrate target. So N2 will continue sending lockres to N1 even though
N1 has left domain.
N1 N2 (owner)
touch file
access the file,
and get pr lock
begin leave domain and
pick up N1 as new owner
begin leave domain and
migrate all lockres done
begin migrate lockres to N1
end leave domain, but
the lockres left
unexpectedly, because
migrate task has passed
[piaojun@huawei.com: v3]
Link: http://lkml.kernel.org/r/5A9CBD19.5020107@huawei.com
Link: http://lkml.kernel.org/r/5A99F028.2090902@huawei.com
Signed-off-by: Jun Piao <piaojun@huawei.com>
Reviewed-by: Yiwen Jiang <jiangyiwen@huawei.com>
Reviewed-by: Joseph Qi <jiangqi903@gmail.com>
Reviewed-by: Changwei Ge <ge.changwei@h3c.com>
Cc: Mark Fasheh <mark@fasheh.com>
Cc: Joel Becker <jlbec@evilplan.org>
Cc: Junxiao Bi <junxiao.bi@oracle.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
59 lines
1.5 KiB
C
59 lines
1.5 KiB
C
/* -*- mode: c; c-basic-offset: 8; -*-
|
|
* vim: noexpandtab sw=8 ts=8 sts=0:
|
|
*
|
|
* dlmdomain.h
|
|
*
|
|
* Copyright (C) 2004 Oracle. All rights reserved.
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2 of the License, or (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public
|
|
* License along with this program; if not, write to the
|
|
* Free Software Foundation, Inc., 59 Temple Place - Suite 330,
|
|
* Boston, MA 021110-1307, USA.
|
|
*
|
|
*/
|
|
|
|
#ifndef DLMDOMAIN_H
|
|
#define DLMDOMAIN_H
|
|
|
|
extern spinlock_t dlm_domain_lock;
|
|
extern struct list_head dlm_domains;
|
|
|
|
static inline int dlm_joined(struct dlm_ctxt *dlm)
|
|
{
|
|
int ret = 0;
|
|
|
|
spin_lock(&dlm_domain_lock);
|
|
if (dlm->dlm_state == DLM_CTXT_JOINED)
|
|
ret = 1;
|
|
spin_unlock(&dlm_domain_lock);
|
|
|
|
return ret;
|
|
}
|
|
|
|
static inline int dlm_shutting_down(struct dlm_ctxt *dlm)
|
|
{
|
|
int ret = 0;
|
|
|
|
spin_lock(&dlm_domain_lock);
|
|
if (dlm->dlm_state == DLM_CTXT_IN_SHUTDOWN)
|
|
ret = 1;
|
|
spin_unlock(&dlm_domain_lock);
|
|
|
|
return ret;
|
|
}
|
|
|
|
void dlm_fire_domain_eviction_callbacks(struct dlm_ctxt *dlm,
|
|
int node_num);
|
|
|
|
#endif
|